Clean up unused LSPIDEServices class

[toinehartman]

While working on the design for #1010, I ran into some unused/obsolete classes.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[DavyLandman]

I'm unsure if this is unused.

What if a DSL does edit from a VS Code action, how will that get wired through to VS Code?

I think the bird IDE contains an example like that.

It might also mean we have to grow our test set before we start working on #1010

[toinehartman]

All the places where services have been replaced with monitor expected an IRascalMonitor, not a more specialized type like the removed LSPIDEServices. All of the IDE services have been moved in #856 IIUC. :edit is here:

rascal-language-servers/rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/terminal/RemoteIDEServicesServer.java

Line 74 in 26ce5f6

public CompletableFuture<Void> edit(ISourceLocation loc, int viewColumn) {

[toinehartman]

Extending the test coverage before rewiring all of this is definitely a good idea.

[toinehartman]

Btw, we already have a test for :edit:

rascal-language-servers/rascal-vscode-extension/src/test/vscode-suite/repl.test.ts

Lines 92 to 98 in 97f83de

	it("edit call module via repl", async() => {
	const repl = new RascalREPL(bench, driver);
	await repl.start();
	await repl.execute(":edit demo::lang::pico::LanguageServer", true, Delays.extremelySlow);
	await driver.wait(async () => await (await bench.getEditorView().getActiveTab())?.getTitle() === "LanguageServer.rsc", Delays.slow, "LanguageServer should be opened");
	});

[DavyLandman]

My concern is about the util::IDEServices::edit function. For which the evaluator casts the monitor to an IDEServices interface if it implements it.

So imagine a VS Code action that has as a side effect edit or perhaps applyDocumentsEdits. This can be both from a rascal evaluator, or a dsl (aka parametric) evaluator.

[toinehartman]

I think this log from the failing test answers your question:

Warning: 1 07:42:29.631 [warning] [parametric-40] org.rascalmpl.vscode.lsp.parametric.InterpretedLanguageContributions[Pico] |unknown:///| : Could not execute FileSystemChange due to File system error: ENOPRO: No file system provider found for resource 'lsp
+file:/' data: "Unavailable" (@1774942949631 ms)

I'll investigate with @rodinaarssen whether we missed something in #856 or how we can solve this otherwise.

[toinehartman]

This was premature and not as unused as thought.