Skip to content

Fix project root computation#1041

Draft
toinehartman wants to merge 15 commits intomainfrom
fix/968-project-roots
Draft

Fix project root computation#1041
toinehartman wants to merge 15 commits intomainfrom
fix/968-project-roots

Conversation

@toinehartman
Copy link
Copy Markdown
Member

@toinehartman toinehartman commented Apr 1, 2026 •
edited
Loading

Rewrite the path config computation to consider several possible scenarios.

Compute the correctly root for

  • Typical source files
  • Source or TPL files in the target directory
  • Nested projects (like example/test projects)

Triggered by, but not a fix for, #968.

@toinehartman toinehartman self-assigned this Apr 1, 2026
@toinehartman toinehartman added the bug Something isn't working label Apr 1, 2026
@toinehartman toinehartman force-pushed the fix/968-project-roots branch from f2f5ffb to 0aba9b1 Compare April 1, 2026 14:02
@toinehartman toinehartman force-pushed the fix/968-project-roots branch from 4fafcc0 to f3c985c Compare April 1, 2026 14:40
@toinehartman toinehartman marked this pull request as ready for review April 1, 2026 14:55
@toinehartman toinehartman changed the title Fix project root/path config computation for modules in std:/// Fix project root/path config computation for modules Apr 1, 2026
@toinehartman toinehartman changed the title Fix project root/path config computation for modules Fix project root/path config computation Apr 1, 2026
@toinehartman toinehartman changed the title Fix project root/path config computation Fix project root computation Apr 1, 2026
DavyLandman
DavyLandman approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@DavyLandman DavyLandman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks okay.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 6, 2026

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
93.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@toinehartman toinehartman marked this pull request as draft April 6, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavyLandman DavyLandman DavyLandman approved these changes

Assignees

@toinehartman toinehartman

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@toinehartman @DavyLandman