Diagnostics of extension-less files are cleared#1066
Merged
DavyLandman merged 6 commits intomainfrom Apr 24, 2026
Merged
Conversation
…ete events (so diagnostics of deleted files can be properly cleared)
toinehartman
requested changes
Apr 22, 2026
Member
toinehartman
left a comment
toinehartman
left a comment
There was a problem hiding this comment.
I believe we need to do this registration dynamically instead of statically.
… all delete events (so diagnostics of deleted files can be properly cleared)" This reverts commit ec0898c.
sungshik
commented
Apr 22, 2026
toinehartman
approved these changes
Apr 24, 2026
DavyLandman
reviewed
Apr 24, 2026
…thub.com/usethesource/rascal-language-servers into clear-diagnostics-of-extensionless-files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1058. It doesn't add UI tests yet, because diagnostics cannot be reliably counted until #1065 is fixed.
With help from @toinehartman.