Factor out text document management#1070
Merged
toinehartman merged 15 commits intomainfrom May 1, 2026
Merged
Conversation
DavyLandman
reviewed
Apr 30, 2026
Member
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
Yes, this is good to factor this out.
I think doing this you've also discovered slight differences between the 2 classes. They are most likely the indication of bugs. Let's smooth that out.
DavyLandman
approved these changes
Apr 30, 2026
Member
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
This looks fine, the tests fail, so maybe there is something there?
|
DavyLandman
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factor out management of open text document contents, reducing the amount of shared code between Rascal and language-parametric LSP implementations. This work also server as preparation for #1010, which will need the same document management on yet another class.