-
Notifications
You must be signed in to change notification settings - Fork 14
Document selectors for capabilities #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
627c6a5
Set document selectors on dynamic capabilities.
toinehartman d746799
Remove duplicate extensions from contributions.
toinehartman b1fe84a
Use orderless mock verification.
toinehartman c806874
Dynamic registration of semantic token capability.
toinehartman 7904a4e
Discover extension-less schemes from associated files.
toinehartman 05efdb5
Merge remote-tracking branch 'origin/main' into fix/capability-docume…
toinehartman 81a9f66
Implement semantic token capability option merge.
toinehartman 9100f66
Refresh editors using LSP instead of close+open.
toinehartman db04507
Simplify filter construction.
toinehartman a371d8d
Get client once.
toinehartman 657e3e9
Only apply contributions to parametric language.
toinehartman 6fd91bf
Use thread-safe set.
toinehartman 030cf1f
Move/add comments on thread-safety of capability updates.
toinehartman fc8db21
Clarify selector wrapping.
toinehartman 8586f9a
Test that open, associated editor is updated on language registration.
toinehartman 9cc7a34
Skip second consecutive unregistration.
toinehartman d00f8a9
Merge branch 'main' into fix/capability-document-selectors
toinehartman a0651ea
Always add contribution-based document selectors to capability-specif…
toinehartman 64d67fd
Merge remote-tracking branch 'origin/main' into fix/capability-docume…
toinehartman 8d5d03e
Merge remote-tracking branch 'origin/main' into fix/capability-docume…
toinehartman aa52ffa
Merge branch 'main' into fix/capability-document-selectors
toinehartman b955cd1
Merge remote-tracking branch 'origin/main' into fix/capability-docume…
toinehartman 8437074
Do not print expected exceptions.
toinehartman db8c580
Fix file rename test.
toinehartman 573add7
Fix test script after #1129.
toinehartman f45f9c0
Fix license check for esbuild after #1129.
toinehartman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 changes: 74 additions & 0 deletions
74
.../main/java/org/rascalmpl/vscode/lsp/parametric/capabilities/SemanticTokensCapability.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /* | ||
| * Copyright (c) 2018-2025, NWO-I CWI and Swat.engineering | ||
| * All rights reserved. | ||
| * | ||
| * Redistribution and use in source and binary forms, with or without | ||
| * modification, are permitted provided that the following conditions are met: | ||
| * | ||
| * 1. Redistributions of source code must retain the above copyright notice, | ||
| * this list of conditions and the following disclaimer. | ||
| * | ||
| * 2. Redistributions in binary form must reproduce the above copyright notice, | ||
| * this list of conditions and the following disclaimer in the documentation | ||
| * and/or other materials provided with the distribution. | ||
| * | ||
| * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
| * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
| * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | ||
| * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE | ||
| * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR | ||
| * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF | ||
| * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS | ||
| * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN | ||
| * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
| * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE | ||
| * POSSIBILITY OF SUCH DAMAGE. | ||
| */ | ||
| package org.rascalmpl.vscode.lsp.parametric.capabilities; | ||
|
|
||
| import java.util.concurrent.CompletableFuture; | ||
| import org.checkerframework.checker.nullness.qual.Nullable; | ||
| import org.eclipse.lsp4j.ClientCapabilities; | ||
| import org.eclipse.lsp4j.SemanticTokensCapabilities; | ||
| import org.eclipse.lsp4j.SemanticTokensWithRegistrationOptions; | ||
| import org.eclipse.lsp4j.ServerCapabilities; | ||
| import org.eclipse.lsp4j.TextDocumentClientCapabilities; | ||
| import org.rascalmpl.vscode.lsp.rascal.conversion.SemanticTokenizer; | ||
| import org.rascalmpl.vscode.lsp.util.Nullables; | ||
|
|
||
| public class SemanticTokensCapability extends AbstractDynamicCapability<SemanticTokensWithRegistrationOptions> { | ||
|
|
||
| public SemanticTokensCapability() { | ||
| super("textDocument/semanticTokens"); | ||
| } | ||
|
|
||
| @Override | ||
| protected CompletableFuture<@Nullable SemanticTokensWithRegistrationOptions> options(ICapabilityParams language) { | ||
| // Note: `mergeOptions` is implemented based on the assumptions that we return a constant here. | ||
| return CompletableFuture.completedFuture(SemanticTokenizer.options()); | ||
| } | ||
|
|
||
| @Override | ||
| protected CompletableFuture<Boolean> isProvidedBy(ICapabilityParams params) { | ||
| return CompletableFuture.completedFuture(true); | ||
| } | ||
|
|
||
| @Override | ||
| protected SemanticTokensWithRegistrationOptions mergeOptions(SemanticTokensWithRegistrationOptions o1, SemanticTokensWithRegistrationOptions o2) { | ||
| // Since `SemanticTokenCapability::options` always returns this, we don't need to do a smart merge here. | ||
| return SemanticTokenizer.options(); | ||
| } | ||
|
|
||
| @Override | ||
| protected boolean isDynamicallySupportedBy(ClientCapabilities clientCapabilities) { | ||
| return Nullables.has(clientCapabilities.getTextDocument(), TextDocumentClientCapabilities::getSemanticTokens, SemanticTokensCapabilities::getDynamicRegistration); | ||
| } | ||
|
|
||
| @Override | ||
| protected void registerStatically(ServerCapabilities capabilities) { | ||
| capabilities.setSemanticTokensProvider(SemanticTokenizer.options()); | ||
| } | ||
|
|
||
| } | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.