test: add failing tests for replace/upsert with complex values (dicts/lists)

Author: nathanjmcdougall

tests/test_document.py

@@ -188,6 +188,67 @@ def test_replace_missing_raises(self):
             doc.replace("missing", value="bar")
 
 
+class TestDocumentReplaceComplex:
+    def test_replace_with_dict(self):
+        doc = Document("config:\n  key: value\n")
+        doc2 = doc.replace("config", value={"key": "new", "extra": "field"})
+        assert doc2["config"] == {"key": "new", "extra": "field"}
+
+    def test_replace_with_list(self):
+        doc = Document("repos: []\n")
+        doc2 = doc.replace(
+            "repos", value=[{"repo": "local", "hooks": [{"id": "my-hook"}]}]
+        )
+        result = doc2["repos"]
+        assert len(result) == 1
+        assert result[0]["repo"] == "local"
+        assert result[0]["hooks"] == [{"id": "my-hook"}]
+
+    def test_replace_with_nested_dict_in_list(self):
+        doc = Document("data:\n  - old\n")
+        doc2 = doc.replace("data", value=[{"a": {"b": [1, 2, 3]}}])
+        assert doc2["data"] == [{"a": {"b": [1, 2, 3]}}]
+
+    def test_replace_complex_preserves_other_keys(self):
+        doc = Document("name: foo\nconfig:\n  key: value\nversion: 1\n")
+        doc2 = doc.replace("config", value={"new_key": "new_val"})
+        assert doc2["name"] == "foo"
+        assert doc2["version"] == 1
+        assert doc2["config"] == {"new_key": "new_val"}
+
+    def test_replace_complex_preserves_comments_on_other_keys(self):
+        doc = Document("name: foo  # keep this\nconfig: old\n")
+        doc2 = doc.replace("config", value={"a": 1})
+        assert "# keep this" in doc2.source
+
+    def test_replace_nested_key_with_dict(self):
+        doc = Document("outer:\n  inner: old\n")
+        doc2 = doc.replace("outer", "inner", value={"a": 1, "b": 2})
+        assert doc2["outer", "inner"] == {"a": 1, "b": 2}
+
+    def test_replace_complex_with_complex(self):
+        doc = Document("config:\n  a: 1\n  b: 2\n")
+        doc2 = doc.replace("config", value={"x": 10, "y": 20})
+        assert doc2["config"] == {"x": 10, "y": 20}
+
+    def test_replace_scalar_with_list(self):
+        doc = Document("items: none\n")
+        doc2 = doc.replace("items", value=["a", "b", "c"])
+        assert doc2["items"] == ["a", "b", "c"]
+
+    def test_replace_deeply_nested_with_dict(self):
+        doc = Document("a:\n  b:\n    c: old\n")
+        doc2 = doc.replace("a", "b", "c", value={"deep": "value"})
+        assert doc2["a", "b", "c"] == {"deep": "value"}
+
+    def test_replace_comment_relocation(self):
+        doc = Document("repos: []  # managed by tool\n")
+        doc2 = doc.replace("repos", value=[{"repo": "local"}])
+        assert "# managed by tool" in doc2.source
+        result = doc2["repos"]
+        assert result == [{"repo": "local"}]
+
+
 class TestDocumentAdd:
     def test_add_key(self):
         doc = Document("name: foo")
@@ -218,6 +279,31 @@ def test_upsert_missing(self):
         assert doc2["age"] == 30
 
 
+class TestDocumentUpsertComplex:
+    def test_upsert_existing_with_dict(self):
+        doc = Document("config:\n  key: value\n")
+        doc2 = doc.upsert("config", value={"key": "new", "extra": "field"})
+        assert doc2["config"] == {"key": "new", "extra": "field"}
+
+    def test_upsert_existing_with_list(self):
+        doc = Document("repos: []\n")
+        doc2 = doc.upsert("repos", value=[{"repo": "local"}])
+        assert doc2["repos"] == [{"repo": "local"}]
+
+    def test_upsert_missing_with_dict(self):
+        """This already works via Op.add — verify it stays working."""
+        doc = Document("name: foo\n")
+        doc2 = doc.upsert("config", value={"a": 1})
+        assert doc2["config"] == {"a": 1}
+        assert doc2["name"] == "foo"
+
+    def test_upsert_missing_with_list(self):
+        """This already works via Op.add — verify it stays working."""
+        doc = Document("name: foo\n")
+        doc2 = doc.upsert("items", value=["a", "b"])
+        assert doc2["items"] == ["a", "b"]
+
+
 class TestDocumentRemove:
     def test_remove_key(self):
         doc = Document("name: foo\nage: 30")