Add device up and device down

Author: ushiboy

README.md

@@ -71,11 +71,11 @@ except Exception as e:
 | device     | status       | supported     |
 | device     | show         | supported     |
 | device     | set          | not supported |
-| device     | up           | not supported |
+| device     | up           | supported     |
 | device     | connect      | supported     |
 | device     | reapply      | supported     |
 | device     | modify       | not supported |
-| device     | down         | not supported |
+| device     | down         | supported     |
 | device     | disconnect   | supported     |
 | device     | delete       | supported     |
 | device     | monitor      | not supported |
@@ -221,6 +221,16 @@ The `fields` argument applies the same effect to the command as the `-f | --fiel
 nmcli.device.show_all(fields: str = None) -> List[DeviceDetails]
 ```
 
+#### nmcli.device.up
+
+Connect the device.
+
+The `wait` argument applies the same effect to the command as the `--wait` option. If it is omitted, the default behavior is followed.
+
+```
+nmcli.device.up(ifname: str, wait: int = None) -> None
+```
+
 #### nmcli.device.connect
 
 Connect the device.
@@ -231,6 +241,16 @@ The `wait` argument applies the same effect to the command as the `--wait` optio
 nmcli.device.connect(ifname: str, wait: int = None) -> None
 ```
 
+#### nmcli.device.down
+
+Disconnect a device and prevent the device from automatically activating further connections without user/manual intervention.
+
+The `wait` argument applies the same effect to the command as the `--wait` option. If it is omitted, the default behavior is followed.
+
+```
+nmcli.device.down(ifname: str, wait: int = None) -> None
+```
+
 #### nmcli.device.disconnect
 
 Disconnect devices.

nmcli/_device.py

@@ -52,9 +52,15 @@ def show(self, ifname: str, fields: str = None) -> DeviceDetails:
     def show_all(self, fields: str = None) -> List[DeviceDetails]:
         raise NotImplementedError
 
+    def up(self, ifname: str, wait: int = None) -> None:
+        raise NotImplementedError
+
     def connect(self, ifname: str, wait: int = None) -> None:
         raise NotImplementedError
 
+    def down(self, ifname: str, wait: int = None) -> None:
+        raise NotImplementedError
+
     def disconnect(self, ifname: str, wait: int = None) -> None:
         raise NotImplementedError
 
@@ -131,11 +137,21 @@ def show_all(self, fields: str = None) -> List[DeviceDetails]:
                 details[key] = None if value in ('--', '""') else value
         return results
 
+    def up(self, ifname: str, wait: int = None) -> None:
+        cmd = add_wait_option_if_needed(
+            wait) + ['device', 'up', ifname]
+        self._syscmd.nmcli(cmd)
+
     def connect(self, ifname: str, wait: int = None) -> None:
         cmd = add_wait_option_if_needed(
             wait) + ['device', 'connect', ifname]
         self._syscmd.nmcli(cmd)
 
+    def down(self, ifname: str, wait: int = None) -> None:
+        cmd = add_wait_option_if_needed(
+            wait) + ['device', 'down', ifname]
+        self._syscmd.nmcli(cmd)
+
     def disconnect(self, ifname: str, wait: int = None) -> None:
         cmd = add_wait_option_if_needed(
             wait) + ['device', 'disconnect', ifname]

nmcli/dummy/_device.py

@@ -5,16 +5,24 @@
 from ..data.hotspot import Hotspot
 
 
-class DummyDeviceControl(DeviceControlInterface):
+class DummyDeviceControl(DeviceControlInterface):  # pylint: disable=too-many-public-methods
 
     @property
     def show_args(self):
         return self._show_args
 
+    @property
+    def up_args(self):
+        return self._up_args
+
     @property
     def connect_args(self):
         return self._connect_args
 
+    @property
+    def down_args(self):
+        return self._down_args
+
     @property
     def disconnect_args(self):
         return self._disconnect_args
@@ -57,7 +65,9 @@ def __init__(self,
         self._result_show_all = result_show_all or []
         self._result_wifi_hotspot = result_wifi_hotspot
         self._show_args: List[Tuple] = []
+        self._up_args: List[Tuple] = []
         self._connect_args: List[Tuple] = []
+        self._down_args: List[Tuple] = []
         self._disconnect_args: List[Tuple] = []
         self._reapply_args: List[str] = []
         self._delete_args: List[Tuple] = []
@@ -85,10 +95,18 @@ def show_all(self, fields: str = None) -> List[DeviceDetails]:
         self._raise_error_if_needed()
         return self._result_show_all
 
+    def up(self, ifname: str, wait: int = None) -> None:
+        self._raise_error_if_needed()
+        self._up_args.append((ifname, wait))
+
     def connect(self, ifname: str, wait: int = None) -> None:
         self._raise_error_if_needed()
         self._connect_args.append((ifname, wait))
 
+    def down(self, ifname: str, wait: int = None) -> None:
+        self._raise_error_if_needed()
+        self._down_args.append((ifname, wait))
+
     def disconnect(self, ifname: str, wait: int = None) -> None:
         self._raise_error_if_needed()
         self._disconnect_args.append((ifname, wait))

tests/test_device.py

@@ -171,6 +171,17 @@ def test_show_all():
     assert s2.passed_parameters == ['-f', 'all', 'device', 'show']
 
 
+def test_up():
+    s = DummySystemCommand()
+    device = DeviceControl(s)
+    ifname = 'eth0'
+    device.up(ifname)
+    assert s.passed_parameters == ['device', 'up', ifname]
+
+    device.up(ifname, wait=10)
+    assert s.passed_parameters == ['--wait', '10', 'device', 'up', ifname]
+
+
 def test_connect():
     s = DummySystemCommand()
     device = DeviceControl(s)
@@ -182,6 +193,18 @@ def test_connect():
     assert s.passed_parameters == ['--wait', '10', 'device', 'connect', ifname]
 
 
+def test_down():
+    s = DummySystemCommand()
+    device = DeviceControl(s)
+    ifname = 'eth0'
+    device.down(ifname)
+    assert s.passed_parameters == ['device', 'down', ifname]
+
+    device.down(ifname, wait=10)
+    assert s.passed_parameters == [
+        '--wait', '10', 'device', 'down', ifname]
+
+
 def test_disconnect():
     s = DummySystemCommand()
     device = DeviceControl(s)