replace all legacy array references

Author: jjergus

.hhconfig

@@ -37,3 +37,5 @@ safe_array = true
 safe_vector_array = true
 typecheck_xhp_cvars = true
 unsafe_rx = false
+allowed_decl_fixme_codes=2053,4047
+allowed_fixme_codes_strict=2011,2049,2050,2053,4026,4027,4047,4053,4104,4107,4108,4110,4128,4135,4188,4200,4240,4248,4323

src/Mock/Param/ParamGeneratorDefaultValue.hh

@@ -22,15 +22,11 @@ final class ParamGeneratorDefaultValue implements ParamGeneratorInterface {
                 $param->getDefaultValue(),
             );
         } else {
-            $default_value = $param->getDefaultValue();
-            if (\is_array($default_value)) {
-                $default_value = '[]';
-            }
             $method->addParameterf(
                 '%s $%s = %s',
                 $param_type_hint,
                 $param->getName(),
-                $default_value,
+                $param->getDefaultValueText(),
             );
         }
     }

src/functions.hh

@@ -86,7 +86,7 @@ function vec_to_string(vec<mixed> $data): string {
 				if (\is_object($param)) {
 					return \get_class($param);
 				}
-				if (\is_array($param)) {
+				if ($param is Traversable<_>) {
 					return vec_to_string(vec($param));
 				}
 				return (string) $param;

tests/Stub/DefaultValueClass.hh

@@ -23,7 +23,7 @@ class DefaultValueClass {
 
     }
 
-    public function defaultNullArray(?array<arraykey, mixed> $param = null): void {
+    public function defaultNullArray(?KeyedContainer<arraykey, mixed> $param = null): void {
 
     }