3 default boolean value (#4)

* Fix default boolean values (#3)

* Clarifying change (#3)

Author: ivyhjk

src/Mock.hh

@@ -61,11 +61,17 @@ final class Mock<TC> implements MockInterface {
 
 				if ($parameter->isDefaultValueAvailable() === true) {
 					if ($parameter->isDefaultValueConstant()) {
+						/**
+						 * HHVM seems to treat default values for bool
+						 * parameters like constants, php does not.
+						 * @see https://github.com/usox/hackmock/issues/3.
+                         * @see https://github.com/usox/hackmock/pull/4.
+						 */
 						$gen_method->addParameterf(
 							'%s $%s = %s',
 							(string) $parameter->getType(),
 							$parameter->getName(),
-							$parameter->getDefaultValue() === null ? 'null' : $parameter->getDefaultValue()
+							$parameter->getDefaultValueText()
 						);
 					} else {
 						if (Str\contains((string) $parameter->getType(), 'string')) {

tests/DefaultValueTest.hh

@@ -0,0 +1,47 @@
+<?hh // strict
+
+use function Usox\HackMock\{mock, prospect};
+
+class DefaultValueTest extends \Usox\HackMock\HackMock {
+    public function testDefaultBooleanFalse(): void {
+        $mock = mock(Stub\DefaultValueClass::class);
+
+        prospect($mock, 'defaultBooleanFalse')->execute(vec[]);
+    }
+
+    public function testDefaultBooleanTrue(): void {
+        $mock = mock(Stub\DefaultValueClass::class);
+
+        prospect($mock, 'defaultBooleanTrue')->execute(vec[]);
+    }
+
+    public function testDefaultNullString(): void {
+        $mock = mock(Stub\DefaultValueClass::class);
+
+        prospect($mock, 'defaultNullString')->execute(vec[]);
+    }
+
+    public function testDefaultNullArray(): void {
+        $mock = mock(Stub\DefaultValueClass::class);
+
+        prospect($mock, 'defaultNullArray')->execute(vec[]);
+    }
+
+    public function testDefaultConstantInt(): void {
+        $mock = mock(Stub\DefaultValueClass::class);
+
+        prospect($mock, 'defaultConstantInt')->execute(vec[]);
+    }
+
+    public function testDefaultConstantString(): void {
+        $mock = mock(Stub\DefaultValueClass::class);
+
+        prospect($mock, 'defaultConstantString')->execute(vec[]);
+    }
+
+    public function testDefaultConstantArraykey(): void {
+        $mock = mock(Stub\DefaultValueClass::class);
+
+        prospect($mock, 'defaultConstantArraykey')->execute(vec[]);
+    }
+}

tests/Stub/DefaultValueClass.hh

@@ -0,0 +1,41 @@
+<?hh // strict
+
+namespace Stub;
+
+/**
+ * Version 1.0.1 just fails with boolean values (#3).
+ * TODO: add more tests cases?.
+ */
+class DefaultValueClass {
+    const int FOO = 0;
+    const string BAR = 'bar';
+    const arraykey BAZ = 1;
+
+    public function defaultBooleanFalse(bool $param = false): void {
+
+    }
+
+    public function defaultBooleanTrue(bool $param = true): void {
+
+    }
+
+    public function defaultNullString(?string $param = null): void {
+
+    }
+
+    public function defaultNullArray(?array<arraykey, mixed> $param = null): void {
+
+    }
+
+    public function defaultConstantInt(int $param = self::FOO): void {
+
+    }
+
+    public function defaultConstantString(string $param = self::BAR): void {
+
+    }
+
+    public function defaultConstantArraykey(arraykey $param = self::BAZ): void {
+
+    }
+}