Address code review feedback - improve type safety and remove redundancies

Co-authored-by: na-trium-144 <100704180+na-trium-144@users.noreply.github.com>

Author: Copilot

app/terminal/exec.tsx

@@ -11,7 +11,6 @@ import { writeOutput } from "./repl";
 import { useState } from "react";
 import { useEmbedContext } from "./embedContext";
 import { useRuntime } from "./runtime";
-import { useWandbox } from "./wandbox/wandbox";
 
 export type ExecLang = "python" | "cpp";
 
@@ -37,7 +36,6 @@ export function ExecFile(props: ExecProps) {
   const sectionContext = useEmbedContext();
 
   const runtime = useRuntime(props.language);
-  const wandbox = useWandbox();
 
   // 表示するコマンドライン文字列
   let commandline: string;
@@ -50,7 +48,9 @@ export function ExecFile(props: ExecProps) {
     if (!props.filenames || props.filenames.length === 0) {
       throw new Error("C++の実行には filenames プロパティが必要です");
     }
-    commandline = wandbox.getCommandlineStr("C++", props.filenames);
+    commandline = runtime.getCommandlineStr
+      ? runtime.getCommandlineStr(props.filenames)
+      : `g++ ${props.filenames.join(" ")}`;
   } else {
     props.language satisfies never;
     commandline = `エラー: 非対応の言語 ${props.language}`;

app/terminal/python/pyodide.tsx

@@ -16,6 +16,7 @@ import { RuntimeContext } from "../runtime";
 
 interface IPyodideContext extends RuntimeContext {
   runPython: (code: string) => Promise<ReplOutput[]>;
+  runCommand: (command: string) => Promise<ReplOutput[]>; // Alias for runPython for consistency
   runFile: (name: string) => Promise<ReplOutput[]>;
 }
 
@@ -231,6 +232,7 @@ export function PyodideProvider({ children }: { children: ReactNode }) {
         initializing,
         ready,
         runPython,
+        runCommand: runPython, // Alias for consistency with RuntimeContext
         checkSyntax,
         mutex: mutex.current,
         runFile,

app/terminal/repl.tsx

@@ -94,11 +94,11 @@ export function ReplTerminal(props: ReplComponentProps) {
 
   const sendCommand = useCallback(
     async (command: string) => {
-      // Python の場合は runPython があればそれを使用、なければ runFiles
-      if ("runPython" in runtime && typeof runtime.runPython === "function") {
-        return runtime.runPython(command);
+      // Use runCommand if available (for REPL), otherwise use runFiles
+      if (runtime.runCommand) {
+        return runtime.runCommand(command);
       }
-      // それ以外の言語では runFiles を使用（ただし REPL として使用しないので通常呼ばれない）
+      // Fallback for languages without REPL support
       return runtime.runFiles([command]);
     },
     [runtime]

app/terminal/runtime.ts

@@ -12,9 +12,11 @@ export interface RuntimeContext {
   ready: boolean;
   mutex: MutexInterface;
   runFiles: (filenames: string[]) => Promise<ReplOutput[]>;
+  runCommand?: (command: string) => Promise<ReplOutput[]>; // For REPL command execution
   checkSyntax?: (code: string) => Promise<SyntaxStatus>;
   interrupt?: () => void;
   splitContents?: (content: string) => ReplCommand[];
+  getCommandlineStr?: (filenames: string[]) => string; // For displaying command line
   // Language-specific properties
   prompt?: string;
   promptMore?: string;

app/terminal/wandbox/wandbox.tsx

@@ -11,8 +11,8 @@ import { MutexInterface } from "async-mutex";
 type WandboxLang = "C++";
 
 interface IWandboxContext extends RuntimeContext {
-  // 表示用のコマンドライン文字列を取得
-  getCommandlineStr: (lang: WandboxLang, filenames: string[]) => string;
+  // 表示用のコマンドライン文字列を取得 (language-specific version)
+  getCommandlineStrWithLang: (lang: WandboxLang, filenames: string[]) => string;
 }
 
 const WandboxContext = createContext<IWandboxContext>(null!);
@@ -50,6 +50,12 @@ export function WandboxProvider({ children }: { children: ReactNode }) {
     [compilerList]
   );
 
+  // Wrapper for RuntimeContext compatibility
+  const getCommandlineStrSimple = useCallback(
+    (filenames: string[]) => getCommandlineStr("C++", filenames),
+    [getCommandlineStr]
+  );
+
   const runFilesWithLang = useCallback(
     async (lang: WandboxLang, filenames: string[]) => {
       if (!compilerList) {
@@ -85,11 +91,18 @@ export function WandboxProvider({ children }: { children: ReactNode }) {
     // Wandbox doesn't need initialization
   }, []);
 
-  // Create a simple mutex that just executes the function
+  // Create a simple mutex that just executes the function immediately
+  // Wandbox doesn't need mutex locking as it makes synchronous API calls
   const mutex: MutexInterface = {
-    runExclusive: async <T,>(fn: () => Promise<T>) => fn(),
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  } as any;
+    runExclusive: async <T,>(fn: () => Promise<T> | T) => fn(),
+    acquire: async () => {
+      return () => {}; // Release function (no-op)
+    },
+    waitForUnlock: async () => {},
+    isLocked: () => false,
+    cancel: () => {},
+    release: () => {},
+  };
 
   return (
     <WandboxContext.Provider
@@ -99,7 +112,8 @@ export function WandboxProvider({ children }: { children: ReactNode }) {
         ready,
         mutex,
         runFiles,
-        getCommandlineStr,
+        getCommandlineStr: getCommandlineStrSimple, // RuntimeContext compatible version
+        getCommandlineStrWithLang: getCommandlineStr, // Language-specific version
       }}
     >
       {children}