remove usage of old external "mock" module#18
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 99 99
Branches 25 25
=========================================
Hits 99 99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the usage of the external "mock" module, switching to the standard library's unittest.mock in tests and updating workflow dependencies accordingly.
- Removed the outdated import of "mock" in tests/test_unordered.py and replaced it with "unittest.mock".
- Updated the GitHub Actions workflows to eliminate installation of the external mock dependency.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_unordered.py | Removed external mock import and replaced with unittest.mock |
| .github/workflows/test.yml | Removed dependency installation of mock/types-mock from workflows |
Files not reviewed (1)
- tox.ini: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Maintainer,
mock has now been merged in the standard library a long time ago,
please consider removing this old external dependency
https://github.com/testing-cabal/mock
mock is now part of the Python standard library, available as unittest.mock in Python 3.3 onwards.