Handle generated columns in dump

Fixes rogerbinns#556

I also audited all other uses of table_info and they are fine
staying as that because we do want to deal with generated
columns as regular ones in those cases

Author: rogerbinns

apsw/shell.py

@@ -1491,7 +1491,13 @@ def sqldef(s):
                             self.write(self.stdout, "DROP TABLE IF EXISTS " + self._fmt_sql_identifier(table) + ";\n")
                             self.write(self.stdout, sqldef(sql[0]))
                             self._output_table = self._fmt_sql_identifier(table)
-                            self.process_sql("select * from " + self._fmt_sql_identifier(table), internal=True)
+                            columns = ",".join(
+                                self._fmt_sql_identifier(column)
+                                for (column,) in self.db.execute(
+                                    "select name from pragma_table_xinfo(?) where hidden=0", (table,)
+                                )
+                            )
+                            self.process_sql(f"select {columns} from " + self._fmt_sql_identifier(table), internal=True)
                         # Now any indices or triggers
                         first = True
                         for name, sql in self.db.execute(

apsw/tests.py

@@ -5383,6 +5383,38 @@ def __init__(self):
         except ZeroDivisionError:
             pass
 
+    def testIssue556(self):
+        "shell dump with generated columns"
+        self.db.execute("""
+           create table t(one, two GENERATED ALWAYS AS (one + 2), three, four GENERATED ALWAYS AS (three + 4));
+           insert into t values(1, 1), (2, 2), (3, 4);
+        """)
+
+        output = io.StringIO()
+        apsw.Shell(db=self.db, stdout=output).process_command(".dump")
+        dump = output.getvalue()
+
+        self.assertIn("GENERATED ALWAYS", dump)
+
+        self.db.execute("drop table t")
+        self.db.execute(dump)
+
+        # make sure the table defition survived
+        self.assertEqual(
+            self.db.execute("select * from pragma_table_xinfo('t')").get,
+            [
+                (0, "one", "", 0, None, 0, 0),
+                (1, "two", "", 0, None, 0, 2),
+                (2, "three", "", 0, None, 0, 0),
+                (3, "four", "", 0, None, 0, 2),
+            ],
+        )
+
+        # and the contents
+        self.assertEqual(
+            self.db.execute("select * from t order by one").get, [(1, 3, 1, 5), (2, 4, 2, 6), (3, 5, 4, 8)]
+        )
+
     def testCursorGet(self):
         "Cursor.get"
         for query, expected in (

doc/changes.rst

@@ -13,7 +13,7 @@ APSW changes by version
 3.49.2.0
 ========
 
-No APSW changes.
+Shell dump command handles generated columns correctly. (:issue:`556`)
 
 3.49.1.0
 ========