Skip to content

Commit af1387e

Browse files
committed
feat(chore): resolve merge conflict
Signed-off-by: Manuel Abascal <mjabascal10@gmail.com>
1 parent fe9d8fd commit af1387e

File tree

2 files changed

+7
-31
lines changed

2 files changed

+7
-31
lines changed

frontend/src/app/app-management/layout/app-management-sidebar/app-management-sidebar.component.html

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -154,33 +154,6 @@
154154

155155

156156

157-
<ng-container *appHasAnyAuthority="adminAuth">
158-
159-
<a *appIsEnterpriseModule="'AUTH_WITH_PROVIDERS_MODULE', else community"
160-
class="list-group-item"
161-
routerLink="/app-management/settings/providers"
162-
routerLinkActive="router-link-active">
163-
<span class="font-weight-semibold">
164-
<i class="icon-shield-check font-size-sm"></i>&nbsp;
165-
Identity Providers
166-
</span>
167-
</a>
168-
169-
<ng-template #community>
170-
<a
171-
(click)="modalVersionInfoService.showVersionInfo()"
172-
class="list-group-item">
173-
<span class="font-weight-semibold">
174-
<i class="icon-shield-check font-size-sm"></i>&nbsp;
175-
Identity Providers
176-
</span>
177-
</a>
178-
</ng-template>
179-
180-
</ng-container>
181-
182-
183-
184157
<a *appHasAnyAuthority="adminAuth"
185158
class="list-group-item"
186159
routerLink="/app-management/settings/about"

frontend/src/app/shared/components/code-editor/code-editor.component.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ export interface ConsoleOptions {
2121
wordWrap?: 'off' | 'on' | 'wordWrapColumn' | 'bounded';
2222
automaticLayout?: boolean;
2323
lineNumbers?: 'off' | 'on';
24+
cursorSmoothCaretAnimation?: 'off' | 'on';
2425
}
2526

2627
const SQL_KEYWORDS = ['CREATE', 'DROP', 'ALTER', 'TRUNCATE',
@@ -49,6 +50,7 @@ const SQL_KEYWORDS = ['CREATE', 'DROP', 'ALTER', 'TRUNCATE',
4950
})
5051
export class CodeEditorComponent implements OnInit, OnDestroy, ControlValueAccessor {
5152
@Input() showFullEditor = true;
53+
@Input() showSuggestions = false;
5254
@Input() consoleOptions?: ConsoleOptions;
5355
@Output() execute = new EventEmitter<string>();
5456
@Output() clearData = new EventEmitter<void>();
@@ -73,7 +75,8 @@ export class CodeEditorComponent implements OnInit, OnDestroy, ControlValueAcces
7375
overviewRulerLanes: 0,
7476
wordWrap: 'on',
7577
automaticLayout: true,
76-
lineNumbers: 'on'
78+
lineNumbers: 'on',
79+
cursorSmoothCaretAnimation: 'off'
7780
};
7881
private completionProvider?: monaco.IDisposable;
7982
private onChange = (_: any) => {};
@@ -92,7 +95,7 @@ export class CodeEditorComponent implements OnInit, OnDestroy, ControlValueAcces
9295
}
9396
}
9497

95-
onEditorInit(editor: monaco.editor.IStandaloneCodeEditor) {
98+
onEditorInit(editorInstance: monaco.editor.IStandaloneCodeEditor) {
9699
this.completionProvider = monaco.languages.registerCompletionItemProvider('sql', {
97100
provideCompletionItems: () => {
98101
const allKeywords = Array.from(new Set([
@@ -110,8 +113,8 @@ export class CodeEditorComponent implements OnInit, OnDestroy, ControlValueAcces
110113
}
111114
});
112115

113-
editor.onDidChangeModelContent(() => {
114-
const val = editor.getValue();
116+
editorInstance.onDidChangeModelContent(() => {
117+
const val = editorInstance.getValue();
115118
this.sqlQuery = val;
116119
this.onChange(val);
117120
this.onTouched();

0 commit comments

Comments
 (0)