fix: improve isEmpty checks for alert target and log objects

Signed-off-by: Manuel Abascal <mjabascal10@gmail.com>

Author: mjabascal10

frontend/src/app/data-management/alert-management/shared/components/alert-host-detail/alert-host-detail.component.ts

@@ -31,9 +31,18 @@ export class AlertHostDetailComponent implements OnInit {
   }
 
   isEmpty(): boolean {
-    return !this.alert || !this.alert[this.type] || Object.keys(this.alert[this.type]).length === 0;
+    const value = this.alert[this.type];
+
+    if (value == null) { return true; }
+
+    if (typeof value !== 'object') { return true; }
+
+    if (Array.isArray(value)) { return value.length === 0; }
+
+    return Object.keys(value).length === 0 && value.constructor === Object;
   }
 
+
   getFields(obj: any, prefix = ''): { id: string; fieldType: UtmFieldType }[] {
     let fields: { id: string, fieldType: UtmFieldType}[] = [];
 

frontend/src/app/data-management/alert-management/shared/components/alert-view-detail/alert-view-detail.component.html

@@ -158,7 +158,7 @@
 
 
     <div class="d-flex w-100 gap-1 justify-content-between mb-3">
-      <app-alert-host-detail *ngIf="alert.target" [alert]="alert" type="target" [hideEmptyField] = true class="w-45"></app-alert-host-detail>
+      <app-alert-host-detail *ngIf="!isEmpty(alert.target)" [alert]="alert" type="target" [hideEmptyField] = true class="w-45"></app-alert-host-detail>
       <app-alert-host-detail  [alert]="alert" type="adversary" [hideEmptyField] = true class="w-45"></app-alert-host-detail>
     </div>
   </div>

frontend/src/app/data-management/alert-management/shared/components/alert-view-detail/alert-view-detail.component.ts

@@ -161,7 +161,16 @@ export class AlertViewDetailComponent implements OnInit {
     return Object.entries(this.log).length === 0;
   }
 
-  protected readonly ALERT_ADVERSARY_FIELD = ALERT_ADVERSARY_FIELD;
+  isEmpty(obj: any): boolean {
+    if (obj == null) { return true; }
+
+    if (typeof obj !== 'object') { return true; }
+
+    if (Array.isArray(obj)) { return obj.length === 0; }
+
+    return Object.keys(obj).length === 0 && obj.constructor === Object;
+  }
+
 }
 
 export enum AlertDetailTabEnum {