Tune bruteforce correlation and drop unreliable PTH rule#2192
Open
JocLRojas wants to merge 4 commits into
Open
Tune bruteforce correlation and drop unreliable PTH rule#2192JocLRojas wants to merge 4 commits into
JocLRojas wants to merge 4 commits into
Conversation
❌ Go dependencies check failedThere are outdated Go dependencies, or modules that could not be inspected. Script output |
|
…ears twice in the deduplicateBy array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed explanation of the changes
Modified —
Modified —
Removed —
Reasoning behind these changes
The two Windows bruteforce correlation rules were grouping prior failed logons only by , so failures coming from unrelated sources against the same account were counted toward the same correlation window. This produced cross-source false positives and inflated alert volume without improving detection quality.
Scoping by and ensures the correlation only fires when the 10 prior failures (and, in the second rule, the subsequent success) actually come from the same source attacking the same user, which is the real bruteforce pattern we want to surface. Extending with the source fields further reduces duplicate alerts for the same source/target pair.
The Pass-the-Hash detection rule was removed because it produced a high false-positive rate on legitimate traffic.
Issue reference
N/A