Skip to content

fix[frontend](parsing_filters): added add entries params on filter form#2327

Open
AlexSanchez-bit wants to merge 2 commits into
release/v12.0.0from
backlog/v12_parsing_filters
Open

fix[frontend](parsing_filters): added add entries params on filter form#2327
AlexSanchez-bit wants to merge 2 commits into
release/v12.0.0from
backlog/v12_parsing_filters

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

🛑 AI review — Engineer review required

This PR touches critical paths or introduces changes the model cannot judge with sufficient confidence. @Kbayero @osmontero please review.

🛑 architecture (gemini-3-flash-lite) — blocking — must fix before merge

Summary: Breaking change to the 'add' parsing filter schema (params changed from array to object), which will break existing configurations and potentially agent-side processing.

  • high frontend/src/features/parsing-filters/lib/filter-model.ts:141 — Schema change: 'params' field changed from Array to Object. This is a breaking change for persisted filter configurations and potentially the agent's parsing logic. Ensure backward compatibility or a migration path.

🛑 bugs (gemini-3-flash-lite) — blocking — must fix before merge

Summary: Breaking change in data structure for 'add' filter step and potential runtime errors in VisualFilterEditor

  • high frontend/src/features/parsing-filters/lib/filter-model.ts:141 — The 'add' filter step configuration structure was changed from an array (params: []) to an object (params: {}). This is a breaking change for existing stored filters that expect an array, which will likely cause runtime errors in existing logic that calls .map() or .length on the 'params' field.
  • medium frontend/src/features/parsing-filters/components/VisualFilterEditor.tsx:293 — The objStr function assumes that 'params' is always an object. If a legacy filter configuration exists where 'params' is still an array (due to the change in emptyStep), obj(key) will return an empty object, effectively losing the existing data and potentially causing UI inconsistencies.

⚠️ security (gemini-3-flash-lite) — non-blocking warnings

Summary: Missing input validation for 'params' object in parsing filter configuration.

  • medium frontend/src/features/parsing-filters/components/VisualFilterEditor.tsx:343 — The 'params' field is now treated as an object with arbitrary key/value pairs without server-side schema validation or sanitization. Ensure the backend validates the structure and content of these parameters to prevent injection or unexpected behavior in the parsing engine.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — AI review found blocking issues (high/critical, or engineer review required). See above.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — AI review found blocking issues (high/critical, or engineer review required). See above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v12 - The parsing-filter view does not show the corresponding parameters for the add step.

1 participant