End sessions cleanly

Author: abnegate

src/Database/Adapter/Mongo.php

@@ -116,6 +116,13 @@ public function withTransaction(callable $callback): mixed
                 // and we want to throw the original exception.
             } finally {
                 // Ensure state is cleaned up even if rollback fails
+                if ($this->session) {
+                    try {
+                        $this->client->endSessions([$this->session]);
+                    } catch (\Throwable $endSessionError) {
+                        // Ignore errors when ending session during error cleanup
+                    }
+                }
                 $this->inTransaction = 0;
                 $this->session = null;
             }
@@ -170,6 +177,9 @@ public function commitTransaction(): bool
                     // This is not necessarily a failure, just return success since the transaction was already terminated.
                     $e = $this->processException($e);
                     if ($e instanceof TransactionException) {
+                        if ($this->session) {
+                            $this->client->endSessions([$this->session]);
+                        }
                         $this->session = null;
                         $this->inTransaction = 0;  // Reset counter when transaction is already terminated
                         return true;
@@ -178,6 +188,9 @@ public function commitTransaction(): bool
                 } catch (\Throwable $e) {
                     throw new DatabaseException($e->getMessage(), $e->getCode(), $e);
                 } finally {
+                    if ($this->session) {
+                        $this->client->endSessions([$this->session]);
+                    }
                     $this->session = null;
                 }
 
@@ -186,6 +199,13 @@ public function commitTransaction(): bool
             return true;
         } catch (\Throwable $e) {
             // Ensure cleanup on any failure
+            if ($this->session) {
+                try {
+                    $this->client->endSessions([$this->session]);
+                } catch (\Throwable $endSessionError) {
+                    // Ignore errors when ending session during error cleanup
+                }
+            }
             $this->session = null;
             $this->inTransaction = 0;
             throw new DatabaseException('Failed to commit transaction: ' . $e->getMessage(), $e->getCode(), $e);
@@ -214,13 +234,23 @@ public function rollbackTransaction(): bool
                 } catch (\Throwable $e) {
                     throw new DatabaseException($e->getMessage(), $e->getCode(), $e);
                 } finally {
+                    if ($this->session) {
+                        $this->client->endSessions([$this->session]);
+                    }
                     $this->session = null;
                 }
 
                 return true;
             }
             return true;
         } catch (\Throwable $e) {
+            if ($this->session) {
+                try {
+                    $this->client->endSessions([$this->session]);
+                } catch (\Throwable $endSessionError) {
+                    // Ignore errors when ending session during error cleanup
+                }
+            }
             $this->session = null;
             $this->inTransaction = 0;
             throw new DatabaseException('Failed to rollback transaction: ' . $e->getMessage(), $e->getCode(), $e);