uid change

Author: fogelito

src/Database/Adapter/MariaDB.php

@@ -980,11 +980,22 @@ public function updateDocument(Document $collection, string $id, Document $docum
             $attributes['_createdAt'] = $document->getCreatedAt();
             $attributes['_updatedAt'] = $document->getUpdatedAt();
             $attributes['_permissions'] = json_encode($document->getPermissions());
+            $attributes['_uid'] = $document->getId();
 
             $name = $this->filter($collection);
             $columns = '';
 
             if (!$skipPermissions) {
+                /**
+                 * Permission rows in the _perms table are keyed by the document's
+                 * UID (the _document column). When the UID changes, the existing
+                 * rows must be re-pointed to the new UID before the diff below is
+                 * applied, otherwise the old rows are orphaned and unchanged
+                 * permissions are lost for the new UID.
+                 */
+                $newUid = $document->offsetExists('$id') ? $document->getId() : $id;
+                $uidChanged = $newUid !== $id;
+
                 $sql = "
 			    SELECT _type, _permission
 			    FROM {$this->getSQLTable($name . '_perms')}
@@ -998,7 +1009,8 @@ public function updateDocument(Document $collection, string $id, Document $docum
                  * Get current permissions from the database
                  */
                 $sqlPermissions = $this->getPDO()->prepare($sql);
-                $sqlPermissions->bindValue(':_uid', $document->getId());
+
+                $sqlPermissions->bindValue(':_uid', $id);
 
                 if ($this->sharedTables) {
                     $sqlPermissions->bindValue(':_tenant', $this->tenant);
@@ -1041,6 +1053,26 @@ public function updateDocument(Document $collection, string $id, Document $docum
                     }
                 }
 
+                /**
+                 * Query to re-point existing permissions to the new UID
+                 */
+                if ($uidChanged) {
+                    $sql = "
+				    UPDATE {$this->getSQLTable($name . '_perms')}
+                    SET _document = :_newUid
+                    WHERE _document = :_uid
+                    {$this->getTenantQuery($collection)}
+                ";
+
+                    $stmtRepointPermissions = $this->getPDO()->prepare($sql);
+                    $stmtRepointPermissions->bindValue(':_uid', $id);
+                    $stmtRepointPermissions->bindValue(':_newUid', $newUid);
+
+                    if ($this->sharedTables) {
+                        $stmtRepointPermissions->bindValue(':_tenant', $this->tenant);
+                    }
+                }
+
                 /**
                  * Query to remove permissions
                  */
@@ -1071,7 +1103,7 @@ public function updateDocument(Document $collection, string $id, Document $docum
                     $removeQuery = $this->trigger(Database::EVENT_PERMISSIONS_DELETE, $removeQuery);
 
                     $stmtRemovePermissions = $this->getPDO()->prepare($removeQuery);
-                    $stmtRemovePermissions->bindValue(':_uid', $document->getId());
+                    $stmtRemovePermissions->bindValue(':_uid', $newUid);
 
                     if ($this->sharedTables) {
                         $stmtRemovePermissions->bindValue(':_tenant', $this->tenant);
@@ -1119,7 +1151,7 @@ public function updateDocument(Document $collection, string $id, Document $docum
 
                     $stmtAddPermissions = $this->getPDO()->prepare($sql);
 
-                    $stmtAddPermissions->bindValue(":_uid", $document->getId());
+                    $stmtAddPermissions->bindValue(":_uid", $newUid);
 
                     if ($this->sharedTables) {
                         $stmtAddPermissions->bindValue(":_tenant", $this->tenant);
@@ -1168,7 +1200,7 @@ public function updateDocument(Document $collection, string $id, Document $docum
 
             $sql = "
                 UPDATE {$this->getSQLTable($name)}
-                SET {$columns} _uid = :_newUid
+                SET " . \rtrim($columns, ',') . "
                 WHERE _id=:_sequence
                 {$this->getTenantQuery($collection)}
 			";
@@ -1178,7 +1210,6 @@ public function updateDocument(Document $collection, string $id, Document $docum
             $stmt = $this->getPDO()->prepare($sql);
 
             $stmt->bindValue(':_sequence', $document->getSequence());
-            $stmt->bindValue(':_newUid', $document->getId());
 
             if ($this->sharedTables) {
                 $stmt->bindValue(':_tenant', $this->tenant);
@@ -1209,6 +1240,9 @@ public function updateDocument(Document $collection, string $id, Document $docum
 
             $stmt->execute();
 
+            if (isset($stmtRepointPermissions)) {
+                $stmtRepointPermissions->execute();
+            }
             if (isset($stmtRemovePermissions)) {
                 $stmtRemovePermissions->execute();
             }