Fix types

Author: abnegate

src/Database/Adapter/MariaDB.php

@@ -905,7 +905,7 @@ public function createDocument(string $collection, Document $document): Document
 
             $stmt->execute();
 
-            $document['$sequence'] = $this->pdo->lastInsertId();
+            $document['$sequence'] = (int) $this->pdo->lastInsertId();
 
             if (empty($document['$sequence'])) {
                 throw new DatabaseException('Error creating document empty "$sequence"');
@@ -1656,7 +1656,7 @@ public function find(string $collection, array $queries = [], ?int $limit = 25,
                 unset($results[$index]['_uid']);
             }
             if (\array_key_exists('_id', $document)) {
-                $results[$index]['$sequence'] = $document['_id'];
+                $results[$index]['$sequence'] = (int) $document['_id'];
                 unset($results[$index]['_id']);
             }
             if (\array_key_exists('_tenant', $document)) {

src/Database/Adapter/Postgres.php

@@ -1028,7 +1028,7 @@ public function createDocument(string $collection, Document $document): Document
 
         try {
             $this->execute($stmt);
-            $lastInsertedId = $this->getPDO()->lastInsertId();
+            $lastInsertedId = (int) $this->getPDO()->lastInsertId();
             // Sequence can be manually set as well
             $document['$sequence'] ??= $lastInsertedId;
 
@@ -1541,7 +1541,7 @@ public function find(string $collection, array $queries = [], ?int $limit = 25,
                 unset($results[$index]['_uid']);
             }
             if (\array_key_exists('_id', $document)) {
-                $results[$index]['$sequence'] = $document['_id'];
+                $results[$index]['$sequence'] = (int) $document['_id'];
                 unset($results[$index]['_id']);
             }
             if (\array_key_exists('_tenant', $document)) {

src/Database/Adapter/SQL.php

@@ -369,7 +369,7 @@ public function getDocument(string $collection, string $id, array $queries = [],
         $document = $document[0];
 
         if (\array_key_exists('_id', $document)) {
-            $document['$sequence'] = $document['_id'];
+            $document['$sequence'] = (int) $document['_id'];
             unset($document['_id']);
         }
         if (\array_key_exists('_uid', $document)) {
@@ -460,7 +460,7 @@ public function updateDocuments(string $collection, Document $updates, array $do
         }
 
         foreach ($sequences as $id => $value) {
-            $stmt->bindValue(":_id_{$id}", $value);
+            $stmt->bindValue(":_id_{$id}", $value, \PDO::PARAM_INT);
         }
 
         $attributeIndex = 0;
@@ -1892,7 +1892,7 @@ public function createDocuments(string $collection, array $documents): array
 
             foreach ($documents as $document) {
                 if (isset($sequences[$document->getId()])) {
-                    $document['$sequence'] = $sequences[$document->getId()];
+                    $document['$sequence'] = (int) $sequences[$document->getId()];
                 }
             }
         } catch (PDOException $e) {

src/Database/Adapter/SQLite.php

@@ -609,7 +609,7 @@ public function createDocument(string $collection, Document $document): Document
             $statment->execute();
             $last = $statment->fetch();
 
-            $document['$sequence'] = $last['id'];
+            $document['$sequence'] = (int) $last['id'];
 
             if (isset($stmtPermissions)) {
                 $stmtPermissions->execute();

src/Database/Database.php

@@ -165,8 +165,8 @@ class Database
         ],
         [
             '$id' => '$sequence',
-            'type' => self::VAR_STRING,
-            'size' => Database::LENGTH_KEY,
+            'type' => self::VAR_INTEGER,
+            'size' => 8,
             'required' => true,
             'signed' => true,
             'array' => false,

tests/e2e/Adapter/Scopes/DocumentTests.php

@@ -93,7 +93,7 @@ public function testCreateDocument(): Document
         // Test create document with manual internal id
         $manualIdDocument = $database->createDocument('documents', new Document([
             '$id' => '56000',
-            '$sequence' => '56000',
+            '$sequence' => 56000,
             '$permissions' => [
                 Permission::read(Role::any()),
                 Permission::read(Role::user(ID::custom('1'))),
@@ -292,7 +292,7 @@ public function testCreateDocumentsWithAutoIncrement(): void
 
         for ($i = $sequence; $i <= ($sequence + $count); $i++) {
             $documents[] = new Document([
-                '$sequence' => (string)$i,
+                '$sequence' => $i,
                 '$permissions' => [
                     Permission::read(Role::any()),
                     Permission::create(Role::any()),
@@ -4228,7 +4228,7 @@ public function testExceptionCaseInsensitiveDuplicate(Document $document): Docum
         $database = static::getDatabase();
 
         $document->setAttribute('$id', 'caseSensitive');
-        $document->setAttribute('$sequence', '200');
+        $document->setAttribute('$sequence', 200);
         $database->createDocument($document->getCollection(), $document);
 
         $document->setAttribute('$id', 'CaseSensitive');