address comments

Author: fogelito

src/Database/Adapter/SQL.php

@@ -3195,10 +3195,6 @@ public function find(
             {$sqlLimit};
         ";
 
-        if (!empty($sqlJoin)) {
-            var_dump($sql);
-        }
-
         $sql = $this->trigger(Database::EVENT_DOCUMENT_FIND, $sql);
 
         try {

src/Database/Database.php

@@ -8284,15 +8284,15 @@ public function find(string $collection, array $queries = [], string $forPermiss
             );
         }
 
-        foreach ($context->getCollections() as $_collection) {
-            $documentSecurity = $_collection->getAttribute('documentSecurity', false);
-            $skipAuth = $this->authorization->isValid(new Input($forPermission, $_collection->getPermissionsByType($forPermission)));
+        foreach ($context->getCollections() as $contextCollection) {
+            $documentSecurity = $contextCollection->getAttribute('documentSecurity', false);
+            $skipAuth = $this->authorization->isValid(new Input($forPermission, $contextCollection->getPermissionsByType($forPermission)));
 
-            if (!$skipAuth && !$documentSecurity && $_collection->getId() !== self::METADATA) {
+            if (!$skipAuth && !$documentSecurity && $contextCollection->getId() !== self::METADATA) {
                 throw new AuthorizationException($this->authorization->getDescription());
             }
 
-            $context->addSkipAuth($this->adapter->filter($_collection->getId()), $forPermission, $skipAuth);
+            $context->addSkipAuth($this->adapter->filter($contextCollection->getId()), $forPermission, $skipAuth);
         }
 
         $this->checkQueryTypes($queries);
@@ -8554,15 +8554,15 @@ public function count(string $collection, array $queries = [], ?int $max = null)
             );
         }
 
-        foreach ($context->getCollections() as $_collection) {
-            $documentSecurity = $_collection->getAttribute('documentSecurity', false);
+        foreach ($context->getCollections() as $contextCollection) {
+            $documentSecurity = $contextCollection->getAttribute('documentSecurity', false);
             $skipAuth = $this->authorization->isValid(new Input(self::PERMISSION_READ, $_collection->getRead()));
 
-            if (!$skipAuth && !$documentSecurity && $_collection->getId() !== self::METADATA) {
+            if (!$skipAuth && !$documentSecurity && $contextCollection->getId() !== self::METADATA) {
                 throw new AuthorizationException($this->authorization->getDescription());
             }
 
-            $context->addSkipAuth($this->adapter->filter($_collection->getId()), self::PERMISSION_READ, $skipAuth);
+            $context->addSkipAuth($this->adapter->filter($contextCollection->getId()), self::PERMISSION_READ, $skipAuth);
         }
 
         $this->checkQueryTypes($queries);
@@ -8792,11 +8792,11 @@ public function decode(QueryContext $context, Document $document, array $selects
             $internals[$attribute['$id']] = $attribute;
         }
 
-        foreach ($context->getCollections() as $collection) {
-            foreach ($collection->getAttribute('attributes', []) as $attribute) {
+        foreach ($context->getCollections() as $contextCollection) {
+            foreach ($contextCollection->getAttribute('attributes', []) as $attribute) {
                 $key = $attribute->getAttribute('key', $attribute->getAttribute('$id'));
                 $key = $this->adapter->filter($key);
-                $schema[$collection->getId()][$key] = $attribute->getArrayCopy();
+                $schema[$contextCollection->getId()][$key] = $attribute->getArrayCopy();
             }
         }
 
@@ -8891,11 +8891,11 @@ public function casting(QueryContext $context, Document $document, array $select
             $internals[$attribute['$id']] = $attribute;
         }
 
-        foreach ($context->getCollections() as $collection) {
-            foreach ($collection->getAttribute('attributes', []) as $attribute) {
+        foreach ($context->getCollections() as $contextCollection) {
+            foreach ($contextCollection->getAttribute('attributes', []) as $attribute) {
                 $key = $attribute->getAttribute('key', $attribute->getAttribute('$id'));
                 $key = $this->adapter->filter($key);
-                $schema[$collection->getId()][$key] = $attribute->getArrayCopy();
+                $schema[$contextCollection->getId()][$key] = $attribute->getArrayCopy();
             }
         }