Skip to content

Commit 20a3f71

Browse files
committed
Update by internalId
1 parent 2d8f25e commit 20a3f71

2 files changed

Lines changed: 5 additions & 14 deletions

File tree

src/Database/Adapter/MariaDB.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1294,24 +1294,19 @@ public function updateDocument(string $collection, string $id, Document $documen
12941294
$bindIndex++;
12951295
}
12961296

1297-
$sqlInternalId = empty($document->getInternalId()) ? '' : ' and _id=:_internalId';
1298-
12991297
$sql = "
13001298
UPDATE {$this->getSQLTable($name)}
13011299
SET {$columns} _uid = :_newUid
1302-
WHERE _uid = :_existingUid {$sqlInternalId}
1300+
WHERE _id=:_internalId
13031301
{$this->getTenantQuery($collection)}
13041302
";
13051303

13061304
$sql = $this->trigger(Database::EVENT_DOCUMENT_UPDATE, $sql);
13071305

13081306
$stmt = $this->getPDO()->prepare($sql);
13091307

1310-
$stmt->bindValue(':_existingUid', $id);
1308+
$stmt->bindValue(':_internalId', $document->getInternalId());
13111309
$stmt->bindValue(':_newUid', $document->getId());
1312-
if (!empty($document->getInternalId())) {
1313-
$stmt->bindValue(':_internalId', $document->getInternalId());
1314-
}
13151310

13161311
if ($this->sharedTables) {
13171312
$stmt->bindValue(':_tenant', $this->tenant);

src/Database/Adapter/Postgres.php

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1334,24 +1334,20 @@ public function updateDocument(string $collection, string $id, Document $documen
13341334
$bindIndex++;
13351335
}
13361336

1337-
$sqlInternalId = empty($document->getInternalId()) ? '' : ' and _id=:_internalId';
1338-
13391337
$sql = "
13401338
UPDATE {$this->getSQLTable($name)}
13411339
SET {$columns} _uid = :_newUid
1342-
WHERE _uid = :_existingUid {$sqlInternalId}
1340+
WHERE _id=:_internalId
13431341
{$this->getTenantQuery($collection)}
13441342
";
13451343

13461344
$sql = $this->trigger(Database::EVENT_DOCUMENT_UPDATE, $sql);
13471345

13481346
$stmt = $this->getPDO()->prepare($sql);
13491347

1350-
$stmt->bindValue(':_existingUid', $id);
1348+
$stmt->bindValue(':_internalId', $document->getInternalId());
1349+
13511350
$stmt->bindValue(':_newUid', $document->getId());
1352-
if (!empty($document->getInternalId())) {
1353-
$stmt->bindValue(':_internalId', $document->getInternalId());
1354-
}
13551351

13561352
if ($this->sharedTables) {
13571353
$stmt->bindValue(':_tenant', $this->tenant);

0 commit comments

Comments
 (0)