SQLite.php

Author: fogelito

src/Database/Adapter/SQLite.php

@@ -1275,6 +1275,7 @@ public function updateDocument(Document $collection, string $id, Document $docum
         $attributes['_createdAt'] = $document->getCreatedAt();
         $attributes['_updatedAt'] = $document->getUpdatedAt();
         $attributes['_permissions'] = json_encode($document->getPermissions());
+        $attributes['_uid'] = $document->getId();
 
         if ($this->sharedTables) {
             $attributes['_tenant'] = $this->tenant;
@@ -1284,116 +1285,33 @@ public function updateDocument(Document $collection, string $id, Document $docum
         $columns = '';
 
         if (!$skipPermissions) {
+            $newUid = $document->offsetExists('$id') ? $document->getId() : $id;
+
             $sql = "
-			SELECT _type, _permission
-			FROM `{$this->getNamespace()}_{$name}_perms`
+			DELETE FROM `{$this->getNamespace()}_{$name}_perms`
 			WHERE _document = :_uid
 			{$this->getTenantQuery($collection)}
 		";
 
-            $sql = $this->trigger(Database::EVENT_PERMISSIONS_READ, $sql);
-
-            /**
-             * Get current permissions from the database
-             */
-            $permissionsStmt = $this->getPDO()->prepare($sql);
-            $permissionsStmt->bindValue(':_uid', $document->getId());
+            $sql = $this->trigger(Database::EVENT_PERMISSIONS_DELETE, $sql);
 
+            $stmtRemovePermissions = $this->getPDO()->prepare($sql);
+            $stmtRemovePermissions->bindValue(':_uid', $id);
             if ($this->sharedTables) {
-                $permissionsStmt->bindValue(':_tenant', $this->tenant);
-            }
-
-            $permissionsStmt->execute();
-            $permissions = $permissionsStmt->fetchAll();
-            $permissionsStmt->closeCursor();
-
-            $initial = [];
-            foreach (Database::PERMISSIONS as $type) {
-                $initial[$type] = [];
-            }
-
-            $permissions = array_reduce($permissions, function (array $carry, array $item) {
-                $carry[$item['_type']][] = $item['_permission'];
-
-                return $carry;
-            }, $initial);
-
-            /**
-             * Get removed Permissions
-             */
-            $removals = [];
-            foreach (Database::PERMISSIONS as $type) {
-                $diff = \array_diff($permissions[$type], $document->getPermissionsByType($type));
-                if (!empty($diff)) {
-                    $removals[$type] = $diff;
-                }
+                $stmtRemovePermissions->bindValue(':_tenant', $this->tenant);
             }
 
-            /**
-             * Get added Permissions
-             */
-            $additions = [];
+            $values = [];
+            $binds = [];
             foreach (Database::PERMISSIONS as $type) {
-                $diff = \array_diff($document->getPermissionsByType($type), $permissions[$type]);
-                if (!empty($diff)) {
-                    $additions[$type] = $diff;
-                }
-            }
-
-            /**
-             * Query to remove permissions
-             */
-            $removeQuery = '';
-            if (!empty($removals)) {
-                $removeQuery = ' AND (';
-                foreach ($removals as $type => $permissions) {
-                    $removeQuery .= "(
-                    _type = '{$type}'
-                    AND _permission IN (" . implode(', ', \array_map(fn (string $i) => ":_remove_{$type}_{$i}", \array_keys($permissions))) . ")
-                )";
-                    if ($type !== \array_key_last($removals)) {
-                        $removeQuery .= ' OR ';
-                    }
-                }
-            }
-            if (!empty($removeQuery)) {
-                $removeQuery .= ')';
-                $sql = "
-				DELETE
-                FROM `{$this->getNamespace()}_{$name}_perms`
-                WHERE _document = :_uid
-                {$this->getTenantQuery($collection)}
-			";
-
-                $removeQuery = $sql . $removeQuery;
-                $removeQuery = $this->trigger(Database::EVENT_PERMISSIONS_DELETE, $removeQuery);
-
-                $stmtRemovePermissions = $this->getPDO()->prepare($removeQuery);
-                $stmtRemovePermissions->bindValue(':_uid', $document->getId());
-
-                if ($this->sharedTables) {
-                    $stmtRemovePermissions->bindValue(':_tenant', $this->tenant);
-                }
-
-                foreach ($removals as $type => $permissions) {
-                    foreach ($permissions as $i => $permission) {
-                        $stmtRemovePermissions->bindValue(":_remove_{$type}_{$i}", $permission);
-                    }
+                foreach ($document->getPermissionsByType($type) as $i => $permission) {
+                    $tenantQuery = $this->sharedTables ? ', :_tenant' : '';
+                    $values[] = "(:_uid, '{$type}', :_add_{$type}_{$i} {$tenantQuery})";
+                    $binds[":_add_{$type}_{$i}"] = $permission;
                 }
             }
 
-            /**
-             * Query to add permissions
-             */
-            if (!empty($additions)) {
-                $values = [];
-                foreach ($additions as $type => $permissions) {
-                    foreach ($permissions as $i => $_) {
-                        $tenantQuery = $this->sharedTables ? ', :_tenant' : '';
-                        $values[] = "(:_uid, '{$type}', :_add_{$type}_{$i} {$tenantQuery})";
-                    }
-                }
-
+            if (!empty($values)) {
                 $tenantQuery = $this->sharedTables ? ', _tenant' : '';
 
                 $sql = "
@@ -1403,16 +1321,13 @@ public function updateDocument(Document $collection, string $id, Document $docum
                 $sql = $this->trigger(Database::EVENT_PERMISSIONS_CREATE, $sql);
 
                 $stmtAddPermissions = $this->getPDO()->prepare($sql);
-
-                $stmtAddPermissions->bindValue(":_uid", $document->getId());
+                $stmtAddPermissions->bindValue(":_uid", $newUid);
                 if ($this->sharedTables) {
                     $stmtAddPermissions->bindValue(":_tenant", $this->tenant);
                 }
 
-                foreach ($additions as $type => $permissions) {
-                    foreach ($permissions as $i => $permission) {
-                        $stmtAddPermissions->bindValue(":_add_{$type}_{$i}", $permission);
-                    }
+                foreach ($binds as $key => $permission) {
+                    $stmtAddPermissions->bindValue($key, $permission);
                 }
             }
         }
@@ -1456,7 +1371,7 @@ public function updateDocument(Document $collection, string $id, Document $docum
 
         $sql = "
 			UPDATE `{$this->getNamespace()}_{$name}`
-			SET {$columns}, _uid = :_newUid
+			SET {$columns}
 			WHERE _uid = :_existingUid
 			{$this->getTenantQuery($collection)}
 		";
@@ -1466,7 +1381,6 @@ public function updateDocument(Document $collection, string $id, Document $docum
         $stmt = $this->getPDO()->prepare($sql);
 
         $stmt->bindValue(':_existingUid', $id);
-        $stmt->bindValue(':_newUid', $document->getId());
 
         if ($this->sharedTables) {
             $stmt->bindValue(':_tenant', $this->tenant);