clean up

Author: shimonewman

tests/e2e/Adapter/Scopes/CollectionTests.php

@@ -649,15 +649,12 @@ public function testCreateCollectionWithSchemaIndexes(): void
             ]),
         ];
 
-        /**
-         *  Update array length check to 255
-         */
         $indexes = [
             new Document([
                 '$id' => ID::custom('idx_cards'),
                 'type' => Database::INDEX_KEY,
                 'attributes' => ['cards'],
-                'lengths' => [500],
+                'lengths' => [500], // Will be changed to Database::ARRAY_INDEX_LENGTH (255)
                 'orders' => [Database::ORDER_DESC],
             ]),
             new Document([
@@ -686,10 +683,6 @@ public function testCreateCollectionWithSchemaIndexes(): void
         );
 
         $this->assertEquals($collection->getAttribute('indexes')[0]['attributes'][0], 'cards');
-        /**
-         * If we set getMaxIndexLength to 1024 then this tests pass but other tests that depend on index length fail
-         */
-
         $this->assertEquals($collection->getAttribute('indexes')[0]['lengths'][0], Database::ARRAY_INDEX_LENGTH);
         $this->assertEquals($collection->getAttribute('indexes')[0]['orders'][0], null);
 

tests/e2e/Adapter/Scopes/DocumentTests.php

@@ -1405,21 +1405,14 @@ public function testFindBasicChecks(): void
         ]);
         $this->assertEquals($firstDocumentId, $documents[0]->getId());
 
-    /**
+        /**
          * Check internal numeric ID sorting
          */
         $documents = $database->find('movies', [
             Query::limit(25),
             Query::offset(0),
             Query::orderDesc(''),
         ]);
-
-//        foreach ($documents as $document) {
-//            var_dump($document->getAttribute('name'));
-//        }
-//
-//        exit;
-        //var_dump($movieDocuments);
         $this->assertEquals($movieDocuments[\count($movieDocuments) - 1]->getId(), $documents[0]->getId());
         $documents = $database->find('movies', [
             Query::limit(25),
@@ -1985,8 +1978,6 @@ public function testFindOrderByAfterNaturalOrder(): void
             Query::orderDesc(''),
             Query::cursorAfter($movies[1])
         ]);
-        //var_dump($movieDocuments);
-
         $this->assertEquals(2, count($documents));
         $this->assertEquals($movies[2]['name'], $documents[0]['name']);
         $this->assertEquals($movies[3]['name'], $documents[1]['name']);
@@ -2016,7 +2007,6 @@ public function testFindOrderByAfterNaturalOrder(): void
             Query::orderDesc(''),
             Query::cursorAfter($movies[5])
         ]);
-
         $this->assertEmpty(count($documents));
     }
     public function testFindOrderByBeforeNaturalOrder(): void

tests/e2e/Adapter/Scopes/GeneralTests.php

@@ -120,9 +120,6 @@ public function testPreserveDatesUpdate(): void
             'attr1' => 'value3',
         ]));
 
-
-
-
         $newDate = '2000-01-01T10:00:00.000+00:00';
 
         $doc1->setAttribute('$updatedAt', $newDate);
@@ -131,16 +128,12 @@ public function testPreserveDatesUpdate(): void
         $doc1 = $database->getDocument('preserve_update_dates', 'doc1');
         $this->assertEquals($newDate, $doc1->getAttribute('$updatedAt'));
 
-//        var_dump([
-//            '$doc2' => $doc2->getAttribute('$updatedAt'),
-//            '$doc3' => $doc3->getAttribute('$updatedAt'),
-//        ]);
-
         $this->getDatabase()->updateDocuments(
             'preserve_update_dates',
             new Document([
                 '$updatedAt' => $newDate
-            ]), [
+            ]),
+            [
                 Query::equal('$id', [
                     $doc2->getId(),
                     $doc3->getId()