(fix): address PR review comments - return type safety, read hook init, index default, mirror null handling

Author: abnegate

src/Database/Adapter/Mongo.php

@@ -184,6 +184,7 @@ protected function syncReadHooks(): void
      */
     protected function applyReadFilters(array $filters, string $collection, string $forPermission = 'read'): array
     {
+        $this->syncReadHooks();
         foreach ($this->readHooks as $hook) {
             $filters = $hook->applyFilters($filters, $collection, $forPermission);
         }

src/Database/Index.php

@@ -74,7 +74,7 @@ public static function fromDocument(Document $document): self
         /** @var string $key */
         $key = $document->getAttribute('key', $document->getId());
         /** @var string $type */
-        $type = $document->getAttribute('type', 'index');
+        $type = $document->getAttribute('type', IndexType::Key->value);
         /** @var array<string> $attributes */
         $attributes = $document->getAttribute('attributes', []);
         /** @var array<int> $lengths */

src/Database/Mirror.php

@@ -401,20 +401,22 @@ public function createAttribute(string $collection, Attribute $attribute): bool
             $document = $attribute->toDocument();
 
             foreach ($this->writeFilters as $filter) {
-                $filtered = $filter->beforeCreateAttribute(
+                $document = $filter->beforeCreateAttribute(
                     source: $this->source,
                     destination: $this->destination,
                     collectionId: $collection,
                     attributeId: $attribute->key,
                     attribute: $document,
                 );
-                if ($filtered !== null) {
-                    $document = $filtered;
+                if ($document === null) {
+                    break;
                 }
             }
 
-            $filteredAttribute = Attribute::fromDocument($document);
-            $result = $this->destination->createAttribute($collection, $filteredAttribute);
+            if ($document !== null) {
+                $filteredAttribute = Attribute::fromDocument($document);
+                $result = $this->destination->createAttribute($collection, $filteredAttribute);
+            }
         } catch (Throwable $err) {
             $this->logError('createAttribute', $err);
         }
@@ -441,25 +443,29 @@ public function createAttributes(string $collection, array $attributes): bool
                 $document = $attribute->toDocument();
 
                 foreach ($this->writeFilters as $filter) {
-                    $filtered = $filter->beforeCreateAttribute(
+                    $document = $filter->beforeCreateAttribute(
                         source: $this->source,
                         destination: $this->destination,
                         collectionId: $collection,
                         attributeId: $attribute->key,
                         attribute: $document,
                     );
-                    if ($filtered !== null) {
-                        $document = $filtered;
+                    if ($document === null) {
+                        break;
                     }
                 }
 
-                $filteredAttributes[] = Attribute::fromDocument($document);
+                if ($document !== null) {
+                    $filteredAttributes[] = Attribute::fromDocument($document);
+                }
             }
 
-            $result = $this->destination->createAttributes(
-                $collection,
-                $filteredAttributes,
-            );
+            if ($filteredAttributes !== []) {
+                $result = $this->destination->createAttributes(
+                    $collection,
+                    $filteredAttributes,
+                );
+            }
         } catch (Throwable $err) {
             $this->logError('createAttributes', $err);
         }

src/Database/Query.php

@@ -44,7 +44,9 @@ public function __construct(Method|string $method, string $attribute = '', array
     public static function parse(string $query): static
     {
         try {
-            return parent::parse($query);
+            $parsed = parent::parse($query);
+
+            return new static($parsed->getMethod(), $parsed->getAttribute(), $parsed->getValues());
         } catch (BaseQueryException $e) {
             throw new QueryException($e->getMessage(), $e->getCode(), $e);
         }
@@ -58,7 +60,9 @@ public static function parse(string $query): static
     public static function parseQuery(array $query): static
     {
         try {
-            return parent::parseQuery($query);
+            $parsed = parent::parseQuery($query);
+
+            return new static($parsed->getMethod(), $parsed->getAttribute(), $parsed->getValues());
         } catch (BaseQueryException $e) {
             throw new QueryException($e->getMessage(), $e->getCode(), $e);
         }