Merge pull request #73 from utopia-php/feat-get-limit-methods-on-database

feat: get limit methods on database

Author: TorstenDittmann

src/Database/Database.php

@@ -1176,4 +1176,27 @@ public function getId(): string
     {
         return \uniqid();
     }
+
+    /**
+     * Get adapter attribute limit, accounting for internal metadata
+     * Returns 0 to indicate no limit
+     *
+     * @return int
+     */
+    public function getAttributeLimit()
+    {
+        // If negative, return 0
+        // -1 ==> virtual columns count as total, so treat as buffer
+        return \max($this->adapter->getAttributeLimit() - $this->adapter->getNumberOfDefaultAttributes() - 1, 0);
+    }
+
+    /**
+     * Get adapter index limit
+     *
+     * @return int
+     */
+    public function getIndexLimit()
+    {
+        return $this->adapter->getIndexLimit() - $this->adapter->getNumberOfDefaultIndexes();
+    }
 }

tests/Database/Adapter/MariaDBTest.php

@@ -39,15 +39,6 @@ static function getAdapterRowLimit(): int
         return MariaDB::getRowLimit();
     }
 
-    /**
-     * 
-     * @return int 
-     */
-    static function getUsedIndexes(): int
-    {
-        return MariaDB::getNumberOfDefaultIndexes();
-    }
-
     /**
      * @return Adapter
      */

tests/Database/Adapter/MongoDBTest.php

@@ -39,15 +39,6 @@ static function getAdapterRowLimit(): int
         return MongoDB::getRowLimit();
     }
 
-    /**
-     * 
-     * @return int 
-     */
-    static function getUsedIndexes(): int
-    {
-        return MongoDB::getNumberOfDefaultIndexes();
-    }
-
     /**
      * @return Adapter
      */

tests/Database/Base.php

@@ -30,11 +30,6 @@ abstract static protected function getAdapterName(): string;
      */
     abstract static protected function getAdapterRowLimit(): int;
 
-    /**
-     * @return int
-     */
-    abstract static protected function getUsedIndexes(): int;
-
     public function setUp(): void
     {
         Authorization::setRole('role:all');
@@ -1270,10 +1265,10 @@ public function testWritePermissionsUpdateFailure(Document $document)
 
     public function testExceptionAttributeLimit()
     {
-        if (static::getAdapterName() === 'mariadb' || static::getAdapterName() === 'mysql') {
+        if ($this->getDatabase()->getAttributeLimit() > 0) {
             // load the collection up to the limit
             $attributes = [];
-            for ($i=0; $i < 1012; $i++) {
+            for ($i=0; $i < $this->getDatabase()->getAttributeLimit(); $i++) {
                 $attributes[] = new Document([
                     '$id' => "test{$i}",
                     'type' => Database::VAR_INTEGER,
@@ -1300,7 +1295,7 @@ public function testExceptionAttributeLimit()
      */
     public function testCheckAttributeCountLimit()
     {
-        if (static::getAdapterName() === 'mariadb' || static::getAdapterName() === 'mysql') {
+        if ($this->getDatabase()->getAttributeLimit() > 0) {
             $collection = static::getDatabase()->getCollection('attributeLimit');
 
             // create same attribute in testExceptionAttributeLimit
@@ -1464,7 +1459,7 @@ public function testExceptionIndexLimit()
         // MariaDB, MySQL, and MongoDB create 3 indexes per new collection
         // MongoDB create 4 indexes per new collection
         // Add up to the limit, then check if the next index throws IndexLimitException
-        for ($i=0; $i < (64 - static::getUsedIndexes()); $i++) {
+        for ($i=0; $i < ($this->getDatabase()->getIndexLimit()); $i++) {
             $this->assertEquals(true, static::getDatabase()->createIndex('indexLimit', "index{$i}", Database::INDEX_KEY, ["test{$i}"], [16]));
         }
         $this->expectException(LimitException::class);
@@ -1543,4 +1538,18 @@ public function testUniqueIndexDuplicateUpdate()
 
         static::getDatabase()->updateDocument('movies', $document->getId(), $document->setAttribute('name',  'Frozen'));
     }
+
+    public function testGetAttributeLimit()
+    {
+        if (static::getAdapterName() === 'mariadb' || static::getAdapterName() === 'mysql') {
+            $this->assertEquals(1012, $this->getDatabase()->getAttributeLimit());
+        } else {
+            $this->assertEquals(0, $this->getDatabase()->getAttributeLimit());
+        }
+    }
+
+    public function testGetIndexLimit()
+    {
+        $this->assertEquals(61, $this->getDatabase()->getIndexLimit());
+    }
 }