Skip to content

Commit 6ce88f4

Browse files
committed
update tests
1 parent 0414b92 commit 6ce88f4

2 files changed

Lines changed: 21 additions & 4 deletions

File tree

src/Database/Database.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -732,10 +732,10 @@ public function on(string $event, string $name, ?callable $callback): static
732732
*
733733
* @param string $event
734734
* @param string $name
735-
* @param callable $callback
735+
* @param ?callable $callback
736736
* @return $this
737737
*/
738-
public function before(string $event, string $name, callable $callback): static
738+
public function before(string $event, string $name, ?callable $callback): static
739739
{
740740
$this->adapter->before($event, $name, $callback);
741741

tests/e2e/Adapter/Scopes/CollectionTests.php

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
namespace Tests\E2E\Adapter\Scopes;
44

55
use Exception;
6+
use Utopia\Database\Adapter\SQL;
67
use Utopia\Database\Database;
78
use Utopia\Database\Document;
89
use Utopia\Database\Exception as DatabaseException;
@@ -1670,13 +1671,29 @@ public function testTransformations(): void
16701671
'name' => 'value1',
16711672
]));
16721673

1673-
$database->before(Database::EVENT_DOCUMENT_READ, 'test', function (string $query) {
1674-
return "SELECT 1";
1674+
$originalMetadata = $database->getMetadata();
1675+
1676+
$database->setMetadata('scope', 'api.users');
1677+
1678+
$capturedSql = '';
1679+
$database->before(Database::EVENT_DOCUMENT_READ, 'test', function (string $sql) use (&$capturedSql) {
1680+
$sql .= ' AND 1=0';
1681+
$capturedSql = $sql;
1682+
return $sql;
16751683
});
16761684

16771685
$result = $database->getDocument('docs', 'doc1');
16781686

16791687
$this->assertTrue($result->isEmpty());
1688+
if (!$database->getAdapter() instanceof SQL) {
1689+
$this->assertStringContainsString('/* scope: api.users */', $capturedSql);
1690+
}
1691+
1692+
$database->before(Database::EVENT_DOCUMENT_READ, 'test', null);
1693+
$database->resetMetadata();
1694+
foreach ($originalMetadata as $key => $value) {
1695+
$database->setMetadata($key, $value);
1696+
}
16801697
}
16811698

16821699
public function testSetGlobalCollection(): void

0 commit comments

Comments
 (0)