Comment option 2

Author: fogelito

src/Database/Database.php

@@ -6675,19 +6675,19 @@ public static function convertQueries(Document $collection, array $queries): arr
         foreach ($attributes as $attribute) {
             foreach ($queries as $index => $query) {
                 if ($query->getAttribute() === $attribute->getId()) {
-                    if($query->getAttribute() === '$sequence'){
-                        /**
-                         * Hack for Postgres, since bindParam does not convert '' on int attribute
-                         */
-                        $values = $query->getValues();
-                        foreach ($values as $valueIndex => $value) {
-                            if($value === ''){
-                                $values[$valueIndex] = '0';
-                            }
-                        }
-                        $query->setValues($values);
-                        $queries[$index] = $query;
-                    }
+//                    if($query->getAttribute() === '$sequence'){
+//                        /**
+//                         * Hack for Postgres, since bindParam does not convert '' on int attribute
+//                         */
+//                        $values = $query->getValues();
+//                        foreach ($values as $valueIndex => $value) {
+//                            if($value === ''){
+//                                $values[$valueIndex] = '0';
+//                            }
+//                        }
+//                        $query->setValues($values);
+//                        $queries[$index] = $query;
+//                    }
 
                     $query->setOnArray($attribute->getAttribute('array', false));
                 }

src/Database/Document.php

@@ -66,7 +66,12 @@ public function getId(): string
      */
     public function getSequence(): string
     {
-        return $this->getAttribute('$sequence', '');
+        /**
+         * This can be a  better fix ?
+         * Since we always check logic by empty($document->getSequence()
+         */
+        return $this->getAttribute('$sequence', '0');
+        //return $this->getAttribute('$sequence', '');
     }
 
     /**

tests/e2e/Adapter/Scopes/DocumentTests.php

@@ -1786,9 +1786,10 @@ public function testFindByInternalID(array $data): void
          * We should not use this fix and use structure validations, or change using not querying on empty string
          */
         $empty = new Document();
+        $this->assertEquals('0', $empty->getSequence());
 
         /**
-         * Check no exceptions are thrown as a temporary fix
+         * Check no exceptions is thrown
          */
         $database->find('movies', [
             Query::equal('$sequence', [$empty->getSequence()]),