Skip to content

Commit a118f46

Browse files
committed
addJoinCollectionId
1 parent 920865a commit a118f46

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

src/Database/Database.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9462,13 +9462,14 @@ private function rollbackAttributeMetadata(Document $collection, array $attribut
94629462
}
94639463

94649464
/**
9465-
* Add Join Collection
9465+
* Add Join CollectionId
94669466
*
94679467
* @param string $collectionId
94689468
* @return void
94699469
*/
9470-
public function addJoinCollection(string $collectionId): void
9470+
public function addJoinCollectionId(string $collectionId): void
94719471
{
9472+
// todo: Consider adding $this->getNamespace()
94729473
$this->joinsCollectionsIds[$collectionId] = true;
94739474
}
94749475
}

tests/e2e/Adapter/Scopes/JoinsTests.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,9 @@ public function testJoin(): void
9393
$this->assertEquals('Invalid query: Cannot InnerJoin this table.', $e->getMessage());
9494
}
9595

96-
$database->addJoinCollection('__users');
97-
$database->addJoinCollection('__sessions');
98-
$database->addJoinCollection('__banks');
96+
$database->addJoinCollectionId('__users');
97+
$database->addJoinCollectionId('__sessions');
98+
$database->addJoinCollectionId('__banks');
9999

100100
/**
101101
* Test $session1 does not have read permissions

0 commit comments

Comments
 (0)