edge cases

Author: fogelito

src/Database/Adapter/MariaDB.php

@@ -2038,11 +2038,10 @@ protected function getOperatorSQL(string $column, Operator $operator, array &$bi
                         // A negative base to a fractional exponent is not a real number.
                         $whens[] = "WHEN {$col} < 0 THEN {$col}";
                     }
-                    // Positive base: compare with logarithms so POWER() never runs on a value that
-                    // would overflow (base^exp > max  <=>  exp * LOG(base) > LOG(max)).
-                    $whens[] = "WHEN {$col} > 0 AND :$bindKey * LOG({$col}) > LOG(:$maxKey) THEN {$col}";
-                    // Non-positive base (no overflow risk): compare the computed value directly.
-                    $whens[] = "WHEN {$col} <= 0 AND POWER({$col}, :$bindKey) > :$maxKey THEN {$col}";
+                    // Compare magnitudes with logarithms so POWER() never runs on a value that would
+                    // overflow (|base|^exp > max  <=>  exp * LOG(|base|) > LOG(max)). Works for both
+                    // signs; ABS() keeps LOG() defined for negative bases with an integer exponent.
+                    $whens[] = "WHEN {$col} <> 0 AND :$bindKey * LOG(ABS({$col})) > LOG(:$maxKey) THEN {$col}";
 
                     $whenSql = \implode(' ', $whens);
                     return "{$quotedColumn} = CASE {$whenSql} ELSE POWER({$col}, :$bindKey) END";

src/Database/Adapter/Postgres.php

@@ -2596,11 +2596,10 @@ protected function getOperatorSQL(string $column, Operator $operator, array &$bi
                     if (\floor($exponent) != $exponent) {
                         $whens[] = "WHEN {$col} < 0 THEN {$col}";
                     }
-                    // Positive base: compare with logarithms so POWER() never runs on a value that
-                    // would overflow (base^exp > max  <=>  exp * LN(base) > LN(max)).
-                    $whens[] = "WHEN {$col} > 0 AND :$bindKey * LN({$col}) > LN(:$maxKey) THEN {$col}";
-                    // Non-positive base (no overflow risk): compare the computed value directly.
-                    $whens[] = "WHEN {$col} <= 0 AND POWER({$col}, :$bindKey) > :$maxKey THEN {$col}";
+                    // Compare magnitudes with logarithms so POWER() never runs on a value that would
+                    // overflow (|base|^exp > max  <=>  exp * LN(|base|) > LN(max)). Works for both
+                    // signs; ABS() keeps LN() defined for negative bases with an integer exponent.
+                    $whens[] = "WHEN {$col} <> 0 AND :$bindKey * LN(ABS({$col})) > LN(:$maxKey) THEN {$col}";
 
                     $whenSql = \implode(' ', $whens);
                     return "{$quotedColumn} = CASE {$whenSql} ELSE POWER({$col}, :$bindKey) END";

src/Database/Adapter/SQLite.php

@@ -2110,11 +2110,10 @@ protected function getOperatorSQL(string $column, Operator $operator, array &$bi
                         // A negative base to a fractional exponent is not a real number.
                         $whens[] = "WHEN {$col} < 0 THEN {$col}";
                     }
-                    // Positive base: compare with logarithms so POWER() never runs on a value that
-                    // would overflow (base^exp > max  <=>  exp * LN(base) > LN(max)).
-                    $whens[] = "WHEN {$col} > 0 AND :$bindKey * LN({$col}) > LN(:$maxKey) THEN {$col}";
-                    // Non-positive base (no overflow risk): compare the computed value directly.
-                    $whens[] = "WHEN {$col} <= 0 AND POWER({$col}, :$bindKey) > :$maxKey THEN {$col}";
+                    // Compare magnitudes with logarithms so POWER() never runs on a value that would
+                    // overflow (|base|^exp > max  <=>  exp * LN(|base|) > LN(max)). Works for both
+                    // signs; ABS() keeps LN() defined for negative bases with an integer exponent.
+                    $whens[] = "WHEN {$col} <> 0 AND :$bindKey * LN(ABS({$col})) > LN(:$maxKey) THEN {$col}";
 
                     $whenSql = \implode(' ', $whens);
                     return "{$quotedColumn} = CASE {$whenSql} ELSE POWER({$col}, :$bindKey) END";

tests/e2e/Adapter/Scopes/OperatorTests.php

@@ -1750,12 +1750,14 @@ public function testOperatorBoundedPowerComputesWithinMax(): void
 
         // [id, starting value, operator, expected stored value].
         $cases = [
-            ['fraction', 0.5, Operator::power(2, 1), 0.25],    // 0.5^2 = 0.25, within max 1 → applied
-            ['negeven', -4.0, Operator::power(2, 20), 16.0],   // (-4)^2 = 16, within max 20 → applied
-            ['within', 2.0, Operator::power(3, 100), 8.0],     // 2^3 = 8, within max 100 → applied
-            ['exceeds', 5.0, Operator::power(3, 100), 5.0],    // 5^3 = 125 > 100 → left unchanged
-            ['negfrac', -4.0, Operator::power(0.5, 100), -4.0], // sqrt(-4) undefined → left unchanged
-            ['zeroneg', 0.0, Operator::power(-1, 100), 0.0],   // 0^-1 undefined → left unchanged
+            ['fraction', 0.5, Operator::power(2, 1), 0.25],      // 0.5^2 = 0.25, within max 1 → applied
+            ['negeven', -4.0, Operator::power(2, 20), 16.0],     // (-4)^2 = 16, within max 20 → applied
+            ['negodd', -2.0, Operator::power(3, 100), -8.0],     // (-2)^3 = -8, within max 100 → applied
+            ['within', 2.0, Operator::power(3, 100), 8.0],       // 2^3 = 8, within max 100 → applied
+            ['exceeds', 5.0, Operator::power(3, 100), 5.0],      // 5^3 = 125 > 100 → left unchanged
+            ['negexceeds', -10.0, Operator::power(100, 100), -10.0], // (-10)^100 far exceeds max → left unchanged (no overflow error)
+            ['negfrac', -4.0, Operator::power(0.5, 100), -4.0],  // sqrt(-4) undefined → left unchanged
+            ['zeroneg', 0.0, Operator::power(-1, 100), 0.0],     // 0^-1 undefined → left unchanged
         ];
 
         foreach ($cases as [$id, $start, $operator, $expected]) {