fix(sql): thread query collection through getSQLCondition as parameter

currentQueryCollection was per-instance mutable state, set by
getSQLConditionsForCollection and read inside SQLite's
getSQLCondition before calling findFulltextTableForAttribute. Under
Swoole, the PRAGMA executed by the lookup yields the coroutine — if
the same statement compiles a second SEARCH after the yield, its
read of currentQueryCollection can land on a value written by a
sibling coroutine. The try/finally save/restore only protected
against sequential leakage, not coroutine interleaving, so the
race could route one coroutine's SEARCH to another's FTS5 table.

Drop the property and add an explicit ?string forCollection
parameter to getSQLCondition / getSQLConditions on the SQL base,
plumb it through MariaDB and Postgres' overrides (and their TYPE_OR
/ TYPE_AND recursive calls), and have SQLite read it from the
parameter. A local parameter cannot race — each coroutine's call
frame holds its own copy across yields.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: abnegate

src/Database/Adapter/MariaDB.php

@@ -1565,7 +1565,7 @@ protected function handleSpatialQueries(Query $query, array &$binds, string $att
      * @return string
      * @throws Exception
      */
-    protected function getSQLCondition(Query $query, array &$binds): string
+    protected function getSQLCondition(Query $query, array &$binds, ?string $forCollection = null): string
     {
         $query->setAttribute($this->getInternalKeyForAttribute($query->getAttribute()));
 
@@ -1585,7 +1585,7 @@ protected function getSQLCondition(Query $query, array &$binds): string
                 $conditions = [];
                 /* @var $q Query */
                 foreach ($query->getValue() as $q) {
-                    $conditions[] = $this->getSQLCondition($q, $binds);
+                    $conditions[] = $this->getSQLCondition($q, $binds, $forCollection);
                 }
 
                 $method = strtoupper($query->getMethod());

src/Database/Adapter/Postgres.php

@@ -1763,7 +1763,7 @@ protected function handleObjectQueries(Query $query, array &$binds, string $attr
      * @return string
      * @throws Exception
      */
-    protected function getSQLCondition(Query $query, array &$binds): string
+    protected function getSQLCondition(Query $query, array &$binds, ?string $forCollection = null): string
     {
         $query->setAttribute($this->getInternalKeyForAttribute($query->getAttribute()));
         $isNestedObjectAttribute = $query->isObjectAttribute() && \str_contains($query->getAttribute(), '.');
@@ -1793,7 +1793,7 @@ protected function getSQLCondition(Query $query, array &$binds): string
                 $conditions = [];
                 /* @var $q Query */
                 foreach ($query->getValue() as $q) {
-                    $conditions[] = $this->getSQLCondition($q, $binds);
+                    $conditions[] = $this->getSQLCondition($q, $binds, $forCollection);
                 }
 
                 $method = strtoupper($query->getMethod());

src/Database/Adapter/SQL.php

@@ -33,16 +33,6 @@ abstract class SQL extends Adapter
      */
     protected int $floatPrecision = 17;
 
-    /**
-     * Filtered collection id of the query currently being built. Set by
-     * find/count/sum (and similar) before delegating to getSQLConditions
-     * so SQL adapter overrides can resolve auxiliary tables (e.g.
-     * SQLite's FTS5 virtual tables) for the active collection.
-     * Lives on the SQL base because Memory has no concept of collection
-     * scoping at this layer.
-     */
-    protected ?string $currentQueryCollection = null;
-
     /**
      * Configure float precision for parameter binding/logging.
      */
@@ -60,22 +50,19 @@ protected function getFloatPrecision(float $value): string
     }
 
     /**
-     * Build SQL conditions for a query while exposing the active collection
-     * via $currentQueryCollection. The state is always reset, even when
-     * getSQLConditions throws — adapter overrides that read it (e.g.
-     * SQLite's FTS5 routing) rely on it being absent outside this scope.
+     * Build SQL conditions for `$name` and thread the collection name down
+     * to the per-query builders. Adapter overrides that need the active
+     * collection (e.g. SQLite's FTS5 routing) read it from this parameter
+     * instead of per-instance state — under Swoole coroutines, instance
+     * state would race across yields if the same statement compiled
+     * multiple SEARCH conditions.
      *
      * @param array<Query> $queries
      * @param array<string,mixed> $binds
      */
     protected function getSQLConditionsForCollection(string $name, array $queries, array &$binds, string $separator = 'AND'): string
     {
-        $this->currentQueryCollection = $name;
-        try {
-            return $this->getSQLConditions($queries, $binds, $separator);
-        } finally {
-            $this->currentQueryCollection = null;
-        }
+        return $this->getSQLConditions($queries, $binds, $separator, $name);
     }
 
     /**
@@ -2341,19 +2328,25 @@ public function getMaxUIDLength(): int
     /**
      * @param Query $query
      * @param array<string, mixed> $binds
+     * @param ?string $forCollection Filtered collection id of the query
+     *        currently being built, threaded through so adapter overrides
+     *        can resolve auxiliary tables (e.g. SQLite's FTS5 virtual
+     *        tables) for the active collection without touching shared
+     *        state that would race across Swoole coroutine yields.
      * @return string
      * @throws Exception
      */
-    abstract protected function getSQLCondition(Query $query, array &$binds): string;
+    abstract protected function getSQLCondition(Query $query, array &$binds, ?string $forCollection = null): string;
 
     /**
      * @param array<Query> $queries
      * @param array<string, mixed> $binds
      * @param string $separator
+     * @param ?string $forCollection See {@see getSQLCondition}.
      * @return string
      * @throws Exception
      */
-    public function getSQLConditions(array $queries, array &$binds, string $separator = 'AND'): string
+    public function getSQLConditions(array $queries, array &$binds, string $separator = 'AND', ?string $forCollection = null): string
     {
         $conditions = [];
         foreach ($queries as $query) {
@@ -2362,9 +2355,9 @@ public function getSQLConditions(array $queries, array &$binds, string $separato
             }
 
             if ($query->isNested()) {
-                $conditions[] = $this->getSQLConditions($query->getValues(), $binds, $query->getMethod());
+                $conditions[] = $this->getSQLConditions($query->getValues(), $binds, $query->getMethod(), $forCollection);
             } else {
-                $conditions[] = $this->getSQLCondition($query, $binds);
+                $conditions[] = $this->getSQLCondition($query, $binds, $forCollection);
             }
         }
 

src/Database/Adapter/SQLite.php

@@ -3131,7 +3131,7 @@ private function parseSqliteColumnType(string $declaration): array
      * escapeWildcards() emits backslash escapes on every wildcard.
      * Everything else falls through to the MariaDB implementation.
      */
-    protected function getSQLCondition(Query $query, array &$binds): string
+    protected function getSQLCondition(Query $query, array &$binds, ?string $forCollection = null): string
     {
         $method = $query->getMethod();
 
@@ -3150,7 +3150,7 @@ protected function getSQLCondition(Query $query, array &$binds): string
         }
 
         if ($method !== Query::TYPE_SEARCH && $method !== Query::TYPE_NOT_SEARCH) {
-            return parent::getSQLCondition($query, $binds);
+            return parent::getSQLCondition($query, $binds, $forCollection);
         }
 
         $query->setAttribute($this->getInternalKeyForAttribute($query->getAttribute()));
@@ -3168,15 +3168,13 @@ protected function getSQLCondition(Query $query, array &$binds): string
             return $method === Query::TYPE_SEARCH ? '1 = 0' : '1 = 1';
         }
 
-        $collection = $this->currentQueryCollection;
-
         // Look the FTS5 table up by attribute rather than computing the
         // name from the attribute alone — multi-column fulltext indexes
         // encode their full sorted attribute set in the table name, so
         // single-attribute searches against them would otherwise miss.
-        $ftsTable = $collection === null
+        $ftsTable = $forCollection === null
             ? null
-            : $this->findFulltextTableForAttribute($collection, $attribute);
+            : $this->findFulltextTableForAttribute($forCollection, $attribute);
 
         if ($ftsTable === null) {
             // No collection context or no matching FTS5 table — fall back