* added dynamic changing of support for attributes to toggle schema and schemaless

* updated ci to include tests with both mongodb support for attributes and not support for attributes

Author: ArnabChatterjee20k

.github/workflows/tests.yml

@@ -85,6 +85,12 @@ jobs:
             SharedTables/Postgres,
             SharedTables/SQLite,
           ]
+        include:
+          - adapter: MongoDB
+            support_for_attributes: false
+          
+          - adapter: MongoDB
+            support_for_attributes: true
 
     steps:
       - name: checkout
@@ -105,4 +111,7 @@ jobs:
 
       - name: Run Tests
         run: docker compose exec -T tests vendor/bin/phpunit /usr/src/code/tests/e2e/Adapter/${{matrix.adapter}}Test.php --debug
+      
+        env:
+          SUPPORT_FOR_ATTRIBUTES: ${{ matrix.support_for_attributes || 'false' }}
 

src/Database/Adapter.php

@@ -1383,4 +1383,12 @@ abstract public function getSupportForUTCCasting(): bool;
     */
     abstract public function setUTCDatetime(string $value): mixed;
 
+    /**
+    * Set support for attributes
+    *
+    * @param bool $support
+    * @return bool
+    */
+    abstract public function setSupportForAttributes(bool $support): bool;
+
 }

src/Database/Adapter/Mongo.php

@@ -57,6 +57,7 @@ class Mongo extends Adapter
      */
     private ?array $session = null; // Store session array from startSession
     protected int $inTransaction = 0;
+    protected bool $supportForAttributes = true;
 
     /**
      * Constructor.
@@ -2585,7 +2586,13 @@ public function setUTCDatetime(string $value): mixed
      */
     public function getSupportForAttributes(): bool
     {
-        return false;
+        return $this->supportForAttributes;
+    }
+
+    public function setSupportForAttributes(bool $support): bool
+    {
+        $this->supportForAttributes = $support;
+        return $this->supportForAttributes;
     }
 
     /**

src/Database/Adapter/Pool.php

@@ -599,4 +599,9 @@ public function setUTCDatetime(string $value): mixed
     {
         return $this->delegate(__FUNCTION__, \func_get_args());
     }
+
+    public function setSupportForAttributes(bool $support): bool
+    {
+        return $this->delegate(__FUNCTION__, \func_get_args());
+    }
 }

src/Database/Adapter/SQL.php

@@ -2930,4 +2930,9 @@ public function decodePolygon(string $wkb): array
 
         return $rings;
     }
+
+    public function setSupportForAttributes(bool $support): bool
+    {
+        return true;
+    }
 }

tests/e2e/Adapter/MongoDBTest.php

@@ -61,6 +61,10 @@ public static function getDatabase(): Database
 
         $database->create();
 
+        $supportForAttributes = getenv('SUPPORT_FOR_ATTRIBUTES');
+        $supportForAttributes = filter_var($supportForAttributes, FILTER_VALIDATE_BOOL);
+        $database->getAdapter()->setSupportForAttributes($supportForAttributes);
+
         return self::$database = $database;
     }
 

tests/e2e/Adapter/Scopes/IndexTests.php

@@ -269,10 +269,10 @@ public function testIndexValidation(): void
 
         $this->assertFalse($validator->isValid($newIndex));
 
-        if ($database->getAdapter()->getSupportForAttributes()) {
-            $this->assertEquals('Attribute "integer" cannot be part of a fulltext index, must be of type string', $validator->getDescription());
-        } elseif (!$database->getAdapter()->getSupportForMultipleFulltextIndexes()) {
+        if (!$database->getAdapter()->getSupportForMultipleFulltextIndexes()) {
             $this->assertEquals('There is already a fulltext index in the collection', $validator->getDescription());
+        } elseif ($database->getAdapter()->getSupportForAttributes()) {
+            $this->assertEquals('Attribute "integer" cannot be part of a fulltext index, must be of type string', $validator->getDescription());
         }
 
         try {