Merge pull request #603 from utopia-php/feat-type-except

Improve increment exceptions

Author: abnegate

src/Database/Database.php

@@ -18,6 +18,7 @@
 use Utopia\Database\Exception\Restricted as RestrictedException;
 use Utopia\Database\Exception\Structure as StructureException;
 use Utopia\Database\Exception\Timeout as TimeoutException;
+use Utopia\Database\Exception\Type as TypeException;
 use Utopia\Database\Helpers\ID;
 use Utopia\Database\Helpers\Permission;
 use Utopia\Database\Helpers\Role;
@@ -4975,7 +4976,7 @@ public function createOrUpdateDocumentsWithIncrease(
                 ->setAttribute('$id', empty($document->getId()) ? ID::unique() : $document->getId())
                 ->setAttribute('$collection', $collection->getId())
                 ->setAttribute('$updatedAt', empty($updatedAt) || !$this->preserveDates ? $time : $updatedAt)
-                ->removeAttribute('$internalId');
+                ->removeAttribute('$sequence');
 
             if ($old->isEmpty()) {
                 $createdAt = $document->getCreatedAt();
@@ -5143,11 +5144,11 @@ public function increaseDocumentAttribute(string $collection, string $id, string
          */
         $attr = \end($attr);
         if (!in_array($attr->getAttribute('type'), $whiteList)) {
-            throw new DatabaseException('Attribute type must be one of: ' . implode(',', $whiteList));
+            throw new TypeException('Attribute type must be one of: ' . implode(',', $whiteList));
         }
 
         if ($max && ($document->getAttribute($attribute) + $value > $max)) {
-            throw new DatabaseException('Attribute value exceeds maximum limit: ' . $max);
+            throw new LimitException('Attribute value exceeds maximum limit: ' . $max);
         }
 
         $time = DateTime::now();
@@ -5234,11 +5235,11 @@ public function decreaseDocumentAttribute(string $collection, string $id, string
          */
         $attr = \end($attr);
         if (!in_array($attr->getAttribute('type'), $whiteList)) {
-            throw new DatabaseException('Attribute type must be one of: ' . implode(',', $whiteList));
+            throw new TypeException('Attribute type must be one of: ' . \implode(',', $whiteList));
         }
 
         if ($min && ($document->getAttribute($attribute) - $value < $min)) {
-            throw new DatabaseException('Attribute value Exceeds minimum limit ' . $min);
+            throw new LimitException('Attribute value exceeds minimum limit: ' . $min);
         }
 
         $time = DateTime::now();

src/Database/Exception/Type.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace Utopia\Database\Exception;
+
+use Utopia\Database\Exception;
+
+class Type extends Exception
+{
+}