updated upsert fix, added sum fix

Author: ArnabChatterjee20k

src/Database/Adapter/SQL.php

@@ -3286,7 +3286,18 @@ public function sum(Document $collection, string $attribute, array $queries = []
 
         $queries = array_map(fn ($query) => clone $query, $queries);
 
-        $conditions = $this->getSQLConditions($queries, $binds);
+        // Extract vector queries (used for ORDER BY) and keep non-vector for WHERE
+        $vectorQueries = [];
+        $otherQueries = [];
+        foreach ($queries as $query) {
+            if (in_array($query->getMethod(), Query::VECTOR_TYPES)) {
+                $vectorQueries[] = $query;
+            } else {
+                $otherQueries[] = $query;
+            }
+        }
+
+        $conditions = $this->getSQLConditions($otherQueries, $binds);
         if (!empty($conditions)) {
             $where[] = $conditions;
         }
@@ -3304,11 +3315,22 @@ public function sum(Document $collection, string $attribute, array $queries = []
             ? 'WHERE ' . \implode(' AND ', $where)
             : '';
 
+        // Add vector distance calculations to ORDER BY (similarity-aware LIMIT)
+        $vectorOrders = [];
+        foreach ($vectorQueries as $query) {
+            $vectorOrder = $this->getVectorDistanceOrder($query, $binds, $alias);
+            if ($vectorOrder) {
+                $vectorOrders[] = $vectorOrder;
+            }
+        }
+        $sqlOrder = !empty($vectorOrders) ? 'ORDER BY ' . implode(', ', $vectorOrders) : '';
+
         $sql = "
 			SELECT SUM({$this->quote($attribute)}) as sum FROM (
 				SELECT {$this->quote($attribute)}
 				FROM {$this->getSQLTable($name)} AS {$this->quote($alias)}
 				{$sqlWhere}
+				{$sqlOrder}
 				{$limit}
 			) table_count
         ";

src/Database/Database.php

@@ -603,12 +603,12 @@ function (mixed $value) {
                 return \json_encode(\array_map(\floatval(...), $value));
             },
             /**
-             * @param mixed $value
+             * @param string|null $value
              * @return array|null
              */
-            function (mixed $value) {
+            function (?string $value) {
                 if (is_null($value)) {
-                    return;
+                    return null;
                 }
                 if (!is_string($value)) {
                     return $value;
@@ -6149,7 +6149,6 @@ public function upsertDocumentsWithIncrease(
 
                 if (!$old->isEmpty()) {
                     $old = $this->adapter->castingAfter($collection, $old);
-                    $old = $this->decode($collection, $old);
                 }
 
                 try {

tests/e2e/Adapter/Scopes/VectorTests.php

@@ -2654,6 +2654,63 @@ public function testVectorQueryCount(): void
         $database->deleteCollection('vectorCount');
     }
 
+    public function testVectorQuerySum(): void
+    {
+        /** @var Database $database */
+        $database = static::getDatabase();
+
+        if (!$database->getAdapter()->getSupportForVectors()) {
+            $this->expectNotToPerformAssertions();
+            return;
+        }
+
+        $database->createCollection('vectorSum');
+        $database->createAttribute('vectorSum', 'embedding', Database::VAR_VECTOR, 3, true);
+        $database->createAttribute('vectorSum', 'value', Database::VAR_INTEGER, 0, true);
+
+        // Create documents with different values
+        $database->createDocument('vectorSum', new Document([
+            '$permissions' => [
+                Permission::read(Role::any())
+            ],
+            'embedding' => [1.0, 0.0, 0.0],
+            'value' => 10
+        ]));
+
+        $database->createDocument('vectorSum', new Document([
+            '$permissions' => [
+                Permission::read(Role::any())
+            ],
+            'embedding' => [0.0, 1.0, 0.0],
+            'value' => 20
+        ]));
+
+        $database->createDocument('vectorSum', new Document([
+            '$permissions' => [
+                Permission::read(Role::any())
+            ],
+            'embedding' => [0.5, 0.5, 0.0],
+            'value' => 30
+        ]));
+
+        // Test sum with vector query - should sum all matching documents
+        $sum = $database->sum('vectorSum', 'value', [
+            Query::vectorCosine('embedding', [1.0, 0.0, 0.0]),
+        ]);
+
+        $this->assertEquals(60, $sum);
+
+        // Test sum with vector query and filter combined
+        $sum = $database->sum('vectorSum', 'value', [
+            Query::vectorCosine('embedding', [1.0, 0.0, 0.0]),
+            Query::greaterThan('value', 15),
+        ]);
+
+        $this->assertEquals(50, $sum);
+
+        $database->deleteCollection('vectorSum');
+    }
+
     public function testVetorUpsert(): void
     {
         /** @var Database $database */