Fix encode

Author: fogelito

src/Database/Database.php

@@ -6293,9 +6293,7 @@ public function encode(Document $collection, Document $document): Document
         $attributes = $collection->getAttribute('attributes', []);
 
         foreach ($this->getInternalAttributes() as $attribute) {
-            if ($attribute['$id'] !== '$permissions') { // Don't encode permissions into a JSON string
-                $attributes[] = new Document($attribute);
-            }
+            $attributes[] = $attribute;
         }
 
         foreach ($attributes as $attribute) {
@@ -6305,6 +6303,13 @@ public function encode(Document $collection, Document $document): Document
             $filters = $attribute['filters'] ?? [];
             $value = $document->getAttribute($key);
 
+            if ($attribute['$id'] === '$permissions') {
+                if (empty($value)){
+                    $document->setAttribute('$permissions', []); // set default value
+                }
+                continue;
+            }
+
             // Continue on optional param with no default
             if (is_null($value) && is_null($default)) {
                 continue;
@@ -6370,12 +6375,13 @@ public function decode(Document $collection, Document $document, array $selectio
         }
 
         foreach ($this->getInternalAttributes() as $attribute) {
-            if ($attribute['$id'] !== '$permissions') {
-                $attributes[] = new Document($attribute);
-            }
+            $attributes[] = $attribute;
         }
 
         foreach ($attributes as $attribute) {
+//            if ($attribute['$id'] === '$permissions') {
+//                continue;
+//            }
             $key = $attribute['$id'] ?? '';
             $array = $attribute['array'] ?? false;
             $filters = $attribute['filters'] ?? [];
@@ -6428,12 +6434,13 @@ public function casting(Document $collection, Document $document): Document
         $attributes = $collection->getAttribute('attributes', []);
 
         foreach ($this->getInternalAttributes() as $attribute) {
-            if ($attribute['$id'] !== '$permissions') {
-                $attributes[] = new Document($attribute);
-            }
+            $attributes[] = $attribute;
         }
 
         foreach ($attributes as $attribute) {
+//            if ($attribute['$id'] === '$permissions') {
+//                continue;
+//            }
             $key = $attribute['$id'] ?? '';
             $type = $attribute['type'] ?? '';
             $array = $attribute['array'] ?? false;

tests/e2e/Adapter/Scopes/PermissionTests.php

@@ -27,8 +27,8 @@ public function testCreateDocumentsEmptyPermission(): void
 
         $document = $database->createDocument(__FUNCTION__, new Document());
 
-        $this->assertArrayNotHasKey('$permissions', $document);
-        $this->assertEquals(null, $document->getAttribute('$permissions'));
+        $this->assertArrayHasKey('$permissions', $document);
+        $this->assertEquals([], $document->getAttribute('$permissions'));
 
         $documents = [];
 
@@ -43,8 +43,8 @@ public function testCreateDocumentsEmptyPermission(): void
 
         $this->assertEquals(2, $count);
         foreach ($results as $result) {
-            $this->assertArrayNotHasKey('$permissions', $result);
-            $this->assertEquals(null, $result->getAttribute('$permissions'));
+            $this->assertArrayHasKey('$permissions', $result);
+            $this->assertEquals([], $result->getAttribute('$permissions'));
         }
     }