removed redundant param from the partial structure

Author: ArnabChatterjee20k

src/Database/Database.php

@@ -4366,14 +4366,12 @@ public function updateDocuments(
         if (!empty($cursor) && $cursor->getCollection() !== $collection->getId()) {
             throw new DatabaseException("Cursor document must be from the same Collection.");
         }
-        $attributesToCheckForRequiredValidation = ['$updatedAt'];
         unset($updates['$id']);
         unset($updates['$tenant']);
         if (($updates->getCreatedAt() === null || !$this->preserveDates)) {
             unset($updates['$createdAt']);
         } else {
             $updates['$createdAt'] = $updates->getCreatedAt();
-            $attributesToCheckForRequiredValidation[] = '$createdAt';
         }
         if ($this->adapter->getSharedTables()) {
             $updates['$tenant'] = $this->adapter->getTenant();
@@ -4390,7 +4388,7 @@ public function updateDocuments(
             $this->adapter->getMaxDateTime(),
         );
 
-        if (!$validator->isValid($updates, $attributesToCheckForRequiredValidation)) {
+        if (!$validator->isValid($updates)) {
             throw new StructureException($validator->getDescription());
         }
 

src/Database/Validator/PartialStructure.php

@@ -13,11 +13,10 @@ class PartialStructure extends Structure
      * Returns true if valid or false if not.
      *
      * @param mixed $document
-     * @param array<int, string> $requiredAttributes optional list of required attributes to check
      *
      * @return bool
      */
-    public function isValid($document, array $requiredAttributes = []): bool
+    public function isValid($document): bool
     {
         if (!$document instanceof Document) {
             $this->message = 'Value must be an instance of Document';
@@ -37,17 +36,14 @@ public function isValid($document, array $requiredAttributes = []): bool
             $name = $attribute['$id'] ?? '';
             $keys[$name] = $attribute;
         }
-        /**
-         * @var array<mixed,mixed> $requiredAttributesMap
-         */
-        $requiredAttributesMap = [];
+        $requiredAttributes = [];
         foreach ($this->attributes as $attribute) {
-            if ($attribute['required'] === true && in_array($attribute['$id'], $requiredAttributes)) {
-                $requiredAttributesMap[] = $attribute;
+            if ($attribute['required'] === true && $document->offsetExists($attribute['$id'])) {
+                $requiredAttributes[] = $attribute;
             }
         }
 
-        if (!$this->checkForAllRequiredValues($structure, $requiredAttributesMap, $keys)) {
+        if (!$this->checkForAllRequiredValues($structure, $requiredAttributes, $keys)) {
             return false;
         }
         if (!$this->checkForUnknownAttributes($structure, $keys)) {

tests/e2e/Adapter/Scopes/DocumentTests.php

@@ -5064,7 +5064,7 @@ public function testBulkDocumentDateOperations(): void
         // Test 5: Bulk upsert operations with custom dates
         $database->setPreserveDates(true);
 
-        // Test 5.1: Bulk upsert with different date configurations
+        // Test 6: Bulk upsert with different date configurations
         $upsertDocuments = [
             new Document([
                 '$id' => 'upsert1',
@@ -5097,7 +5097,7 @@ public function testBulkDocumentDateOperations(): void
             $upsertResults[] = $doc;
         });
 
-        // Verify initial upsert state
+        // Test 7: Verify initial upsert state
         foreach (['upsert1', 'upsert3'] as $id) {
             $doc = $database->getDocument($collection, $id);
             $this->assertEquals($createDate, $doc->getAttribute('$createdAt'), "createdAt mismatch for $id");
@@ -5114,7 +5114,7 @@ public function testBulkDocumentDateOperations(): void
             $this->assertNotEmpty($doc->getAttribute('$updatedAt'), "updatedAt missing for $id");
         }
 
-        // Test 5.2: Bulk upsert update with custom dates using updateDocuments
+        // Test 8: Bulk upsert update with custom dates using updateDocuments
         $newDate = '2000-04-01T12:00:00.000+00:00';
         $updateUpsertDoc = new Document([
             'string' => 'upsert_updated',
@@ -5139,7 +5139,30 @@ public function testBulkDocumentDateOperations(): void
             $this->assertEquals('upsert_updated', $doc->getAttribute('string'), "string mismatch for $id");
         }
 
-        // Test 5.3: Bulk upsert operations with createOrUpdateDocuments
+        // Test 9: checking by passing null to each
+        $updateUpsertDoc = new Document([
+            'string' => 'upsert_updated',
+            '$createdAt' => null,
+            '$updatedAt' => null
+        ]);
+
+        $upsertIds = [];
+        foreach ($upsertDocuments as $doc) {
+            $upsertIds[] = $doc->getId();
+        }
+
+        $countUpsert = $database->updateDocuments($collection, $updateUpsertDoc, [
+            Query::equal('$id', $upsertIds)
+        ]);
+        $this->assertEquals(4, $countUpsert);
+
+        foreach ($upsertIds as $id) {
+            $doc = $database->getDocument($collection, $id);
+            $this->assertNotEmpty($doc->getAttribute('$createdAt'), "createdAt mismatch for $id");
+            $this->assertNotEmpty($doc->getAttribute('$updatedAt'), "updatedAt mismatch for $id");
+        }
+
+        // Test 10: Bulk upsert operations with createOrUpdateDocuments
         $upsertUpdateDocuments = [];
         foreach ($upsertDocuments as $doc) {
             $updatedDoc = clone $doc;
@@ -5161,7 +5184,7 @@ public function testBulkDocumentDateOperations(): void
             $this->assertEquals('upsert_updated_via_upsert', $doc->getAttribute('string'), "string mismatch for upsert update");
         }
 
-        // Test 5.4: Bulk upsert with preserve dates disabled
+        // Test 11: Bulk upsert with preserve dates disabled
         $database->setPreserveDates(false);
 
         $customDate = 'should be ignored anyways so no error';