Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR renames test methods to reflect the upsert behavior and fixes an upsert mismatch while also enhancing optional attribute handling within document updates.
- Renamed test methods from "CreateOrUpdateDocuments" to "UpsertDocuments" variants.
- Added new tests to cover attribute mismatch and no-op upsert scenarios.
- Updated the database document update mechanism to force matching optional parameter sets.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/e2e/Adapter/Scopes/DocumentTests.php | Renaming of test methods and addition of new upsert tests |
| src/Database/Database.php | Enhanced optional attribute handling during upsert operations |
abnegate
added a commit
that referenced
this pull request
May 29, 2025
Fix upsert mismatch # Conflicts: # tests/e2e/Adapter/Scopes/DocumentTests.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses
PDOExceptionthrown when documents contain different sets of optional attributes during upsert