Mongo transactions#625
Closed
shimonewman wants to merge 24 commits intofeat-mongo-2from
Closed
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
…ngo-transactions # Conflicts: # src/Database/Adapter/Mongo.php
abnegate
reviewed
Jul 18, 2025
abnegate
reviewed
Jul 23, 2025
Comment on lines
+92
to
+95
| // If the database is not a replica set, we can't use transactions | ||
| if(!$this->client->isReplicaSet()){ | ||
| return true; | ||
| } |
Member
There was a problem hiding this comment.
In this scenario we should still run the callback and return it's result
| } | ||
|
|
||
| // Session is now closed by the client using endSessions, state is reseted | ||
| // TODO do we want session per transaction or to manage it on the connection level? |
Member
There was a problem hiding this comment.
Session per txn is fine 👍 in fact we will need it that way since Appwrite pools use a different connection for each DB call
Comment on lines
+1010
to
+1013
| /** | ||
| * TODO Do we even need this find? | ||
| * We can just return the result from the insertDocument. | ||
| */ |
Member
There was a problem hiding this comment.
We can just return from insert if that works
…ngo-transactions # Conflicts: # composer.json # composer.lock # src/Database/Adapter/Mongo.php
…nd MongoDB configuration adjustments
…ngo-transactions # Conflicts: # composer.json # composer.lock # src/Database/Adapter/MariaDB.php
…ion handling in Mongo adapter. Updated command for MongoDB to support replica sets and improved transaction callback handling in the adapter.
…ngo-transactions # Conflicts: # src/Database/Adapter/Mongo.php
…e MongoDB replica set and user creation.
Co-authored-by: Jake Barnby <jakeb994@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.