Unique Exception

src/Database/Adapter/MariaDB.php

@@ -12,6 +12,7 @@
 use Utopia\Database\Exception\Query as QueryException;
 use Utopia\Database\Exception\Timeout as TimeoutException;
 use Utopia\Database\Exception\Truncate as TruncateException;
+use Utopia\Database\Exception\Unique as UniqueException;
 use Utopia\Database\Helpers\ID;
 use Utopia\Database\Query;
 
@@ -816,6 +817,7 @@ public function deleteIndex(string $collection, string $id): bool
      * @return Document
      * @throws Exception
      * @throws PDOException
+     * @throws UniqueException
      * @throws DuplicateException
      * @throws \Throwable
      */
@@ -942,6 +944,7 @@ public function createDocument(Document $collection, Document $document): Docume
      * @return Document
      * @throws Exception
      * @throws PDOException
+     * @throws UniqueException
      * @throws DuplicateException
      * @throws \Throwable
      */
@@ -1795,7 +1798,13 @@ protected function processException(PDOException $e): \Exception
 
         // Duplicate row
         if ($e->getCode() === '23000' && isset($e->errorInfo[1]) && $e->errorInfo[1] === 1062) {
-            return new DuplicateException('Document already exists', $e->getCode(), $e);
+            if (preg_match("/for key '(?:[^.]+\.)?([^']+)'/", $e->getMessage(), $matches)) {
+                if ($matches[1] === '_uid') {
+                    return new DuplicateException('Document already exists', $e->getCode(), $e);
+                }
+            }
+
+            return new UniqueException('Document already exists', $e->getCode(), $e);
         }
 
         // Data is too big for column resize

src/Database/Adapter/Postgres.php

@@ -13,6 +13,7 @@
 use Utopia\Database\Exception\Timeout as TimeoutException;
 use Utopia\Database\Exception\Transaction as TransactionException;
 use Utopia\Database\Exception\Truncate as TruncateException;
+use Utopia\Database\Exception\Unique as UniqueException;
 use Utopia\Database\Helpers\ID;
 use Utopia\Database\Query;
 
@@ -1924,7 +1925,16 @@ protected function processException(PDOException $e): \Exception
 
         // Duplicate row
         if ($e->getCode() === '23505' && isset($e->errorInfo[1]) && $e->errorInfo[1] === 7) {
-            return new DuplicateException('Document already exists', $e->getCode(), $e);
+            if (preg_match('/Key \(([^)]+)\)=\(.+\) already exists/', $e->getMessage(), $matches)) {
+                $columns = array_map('trim', explode(',', $matches[1]));
+                sort($columns);
+                $target = $this->sharedTables ? ['_tenant', '_uid'] : ['_uid'];
+                if ($columns == $target) {
+                    return new DuplicateException('Document already exists', $e->getCode(), $e);
+                }
+            }
+
+            return new UniqueException('Document already exists', $e->getCode(), $e);
         }
 
         // Data is too big for column resize

src/Database/Adapter/SQLite.php

@@ -8,11 +8,11 @@
 use Utopia\Database\Database;
 use Utopia\Database\Document;
 use Utopia\Database\Exception as DatabaseException;
-use Utopia\Database\Exception\Duplicate;
 use Utopia\Database\Exception\Duplicate as DuplicateException;
 use Utopia\Database\Exception\NotFound as NotFoundException;
 use Utopia\Database\Exception\Timeout as TimeoutException;
 use Utopia\Database\Exception\Transaction as TransactionException;
+use Utopia\Database\Exception\Unique as UniqueException;
 use Utopia\Database\Helpers\ID;
 
 /**
@@ -517,7 +517,7 @@ public function deleteIndex(string $collection, string $id): bool
      * @return Document
      * @throws Exception
      * @throws PDOException
-     * @throws Duplicate
+     * @throws UniqueException
      */
     public function createDocument(Document $collection, Document $document): Document
     {
@@ -619,10 +619,7 @@ public function createDocument(Document $collection, Document $document): Docume
                 $stmtPermissions->execute();
             }
         } catch (PDOException $e) {
-            throw match ($e->getCode()) {
-                "1062", "23000" => new Duplicate('Duplicated document: ' . $e->getMessage()),
-                default => $e,
-            };
+            throw $this->processException($e);
         }
 
 
@@ -639,7 +636,7 @@ public function createDocument(Document $collection, Document $document): Docume
      * @return Document
      * @throws Exception
      * @throws PDOException
-     * @throws Duplicate
+     * @throws UniqueException
      */
     public function updateDocument(Document $collection, string $id, Document $document, bool $skipPermissions): Document
     {
@@ -841,11 +838,7 @@ public function updateDocument(Document $collection, string $id, Document $docum
                 $stmtAddPermissions->execute();
             }
         } catch (PDOException $e) {
-            throw match ($e->getCode()) {
-                '1062',
-                '23000' => new Duplicate('Duplicated document: ' . $e->getMessage()),
-                default => $e,
-            };
+            throw $this->processException($e);
         }
 
         return $document;
@@ -1248,9 +1241,15 @@ protected function processException(PDOException $e): \Exception
             return new TimeoutException('Query timed out', $e->getCode(), $e);
         }
 
-        // Duplicate
-        if ($e->getCode() === 'HY000' && isset($e->errorInfo[1]) && $e->errorInfo[1] === 1) {
-            return new DuplicateException('Document already exists', $e->getCode(), $e);
+        // Duplicate row
+        if ($e->getCode() === '23000' && isset($e->errorInfo[1]) && $e->errorInfo[1] === 19) {
+            if (preg_match('/UNIQUE constraint failed:\s+([^.]+)\.([^\s]+)/', $e->getMessage(), $m)) {
+                if ($m[2] === '_uid') {
+                    return new DuplicateException('Document already exists', $e->getCode(), $e);
+                }
+            }
+
+            return new UniqueException('Document already exists', $e->getCode(), $e);
         }
 
         return $e;

src/Database/Exception/Unique.php

@@ -0,0 +1,7 @@
+<?php
+
+namespace Utopia\Database\Exception;
+
+class Unique extends Duplicate
+{
+}

tests/e2e/Adapter/Scopes/DocumentTests.php

@@ -14,6 +14,7 @@
 use Utopia\Database\Exception\Limit as LimitException;
 use Utopia\Database\Exception\Structure as StructureException;
 use Utopia\Database\Exception\Type as TypeException;
+use Utopia\Database\Exception\Unique as UniqueException;
 use Utopia\Database\Helpers\ID;
 use Utopia\Database\Helpers\Permission;
 use Utopia\Database\Helpers\Role;
@@ -4729,36 +4730,41 @@ public function testWritePermissionsUpdateFailure(Document $document): Document
      */
     public function testUniqueIndexDuplicate(): void
     {
-        $this->expectException(DuplicateException::class);
-
         /** @var Database $database */
         $database = static::getDatabase();
 
         $this->assertEquals(true, $database->createIndex('movies', 'uniqueIndex', Database::INDEX_UNIQUE, ['name'], [128], [Database::ORDER_ASC]));
 
-        $database->createDocument('movies', new Document([
-            '$permissions' => [
-                Permission::read(Role::any()),
-                Permission::read(Role::user('1')),
-                Permission::read(Role::user('2')),
-                Permission::create(Role::any()),
-                Permission::create(Role::user('1x')),
-                Permission::create(Role::user('2x')),
-                Permission::update(Role::any()),
-                Permission::update(Role::user('1x')),
-                Permission::update(Role::user('2x')),
-                Permission::delete(Role::any()),
-                Permission::delete(Role::user('1x')),
-                Permission::delete(Role::user('2x')),
-            ],
-            'name' => 'Frozen',
-            'director' => 'Chris Buck & Jennifer Lee',
-            'year' => 2013,
-            'price' => 39.50,
-            'active' => true,
-            'genres' => ['animation', 'kids'],
-            'with-dash' => 'Works4'
-        ]));
+        try {
+            $database->createDocument('movies', new Document([
+                '$permissions' => [
+                    Permission::read(Role::any()),
+                    Permission::read(Role::user('1')),
+                    Permission::read(Role::user('2')),
+                    Permission::create(Role::any()),
+                    Permission::create(Role::user('1x')),
+                    Permission::create(Role::user('2x')),
+                    Permission::update(Role::any()),
+                    Permission::update(Role::user('1x')),
+                    Permission::update(Role::user('2x')),
+                    Permission::delete(Role::any()),
+                    Permission::delete(Role::user('1x')),
+                    Permission::delete(Role::user('2x')),
+                ],
+                'name' => 'Frozen',
+                'director' => 'Chris Buck & Jennifer Lee',
+                'year' => 2013,
+                'price' => 39.50,
+                'active' => true,
+                'genres' => ['animation', 'kids'],
+                'with-dash' => 'Works4'
+            ]));
+
+            $this->fail('Failed to throw exception');
+        } catch (Throwable $e) {
+            $this->assertInstanceOf(UniqueException::class, $e);
+            $this->assertInstanceOf(DuplicateException::class, $e);
+        }
     }
     /**
      * @depends testUniqueIndexDuplicate
@@ -4794,9 +4800,14 @@ public function testUniqueIndexDuplicateUpdate(): void
             'with-dash' => 'Works4'
         ]));
 
-        $this->expectException(DuplicateException::class);
+        try {
+            $database->updateDocument('movies', $document->getId(), $document->setAttribute('name', 'Frozen'));
 
-        $database->updateDocument('movies', $document->getId(), $document->setAttribute('name', 'Frozen'));
+            $this->fail('Failed to throw exception');
+        } catch (Throwable $e) {
+            $this->assertInstanceOf(UniqueException::class, $e);
+            $this->assertInstanceOf(DuplicateException::class, $e);
+        }
     }
 
     public function propagateBulkDocuments(string $collection, int $amount = 10, bool $documentSecurity = false): void
@@ -5298,9 +5309,18 @@ public function testExceptionDuplicate(Document $document): void
         $database = static::getDatabase();
 
         $document->setAttribute('$id', 'duplicated');
+        $document->removeAttribute('$sequence');
+
         $database->createDocument($document->getCollection(), $document);
-        $this->expectException(DuplicateException::class);
-        $database->createDocument($document->getCollection(), $document);
+        $document->removeAttribute('$sequence');
+
+        try {
+            $database->createDocument($document->getCollection(), $document);
+            $this->fail('Failed to throw exception');
+        } catch (Throwable $e) {
+            $this->assertInstanceOf(DuplicateException::class, $e);
+            $this->assertNotInstanceOf(UniqueException::class, $e);
+        }
     }
 
     /**
@@ -5312,13 +5332,20 @@ public function testExceptionCaseInsensitiveDuplicate(Document $document): Docum
         $database = static::getDatabase();
 
         $document->setAttribute('$id', 'caseSensitive');
-        $document->setAttribute('$sequence', '200');
-        $database->createDocument($document->getCollection(), $document);
+        $document->removeAttribute('$sequence');
 
-        $document->setAttribute('$id', 'CaseSensitive');
-
-        $this->expectException(DuplicateException::class);
         $database->createDocument($document->getCollection(), $document);
+        $document->setAttribute('$id', 'caseSensitive'); // Revert this
+        $document->removeAttribute('$sequence');
+
+        try {
+            $database->createDocument($document->getCollection(), $document);
+            $this->fail('Failed to throw exception');
+        } catch (Throwable $e) {
+            var_dump($e);
+            $this->assertInstanceOf(DuplicateException::class, $e);
+            $this->assertNotInstanceOf(UniqueException::class, $e);
+        }
 
         return $document;
     }