Skip to content

skipFilters #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fogelito wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

skipFilters #780

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf58516
skipFilters
fogelito Jan 14, 2026
c162434
linter
fogelito Jan 14, 2026
e47fd07
AddSkip
fogelito Jan 14, 2026
87038de
AddSkip
fogelito Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions src/Database/Database.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,9 +393,9 @@ class Database
protected bool $filter = true;

/**
* @var array<string, bool>|null
* @var array<string, bool>
*/
protected ?array $disabledFilters = [];
protected array $disabledFilters = [];

protected bool $validate = true;

Expand Down Expand Up @@ -8463,22 +8463,16 @@ protected function encodeAttribute(string $name, mixed $value, Document $documen
*/
protected function decodeAttribute(string $filter, mixed $value, Document $document, string $attribute): mixed
{
if (!$this->filter) {
return $value;
}

if (!\is_null($this->disabledFilters) && isset($this->disabledFilters[$filter])) {
return $value;
}
$skip = $this->filter === false || isset($this->disabledFilters[$filter]);

if (!array_key_exists($filter, self::$filters) && !array_key_exists($filter, $this->instanceFilters)) {
throw new NotFoundException("Filter \"{$filter}\" not found for attribute \"{$attribute}\"");
}

if (array_key_exists($filter, $this->instanceFilters)) {
$value = $this->instanceFilters[$filter]['decode']($value, $document, $this);
$value = $this->instanceFilters[$filter]['decode']($value, $document, $this, $skip);
} else {
$value = self::$filters[$filter]['decode']($value, $document, $this);
$value = self::$filters[$filter]['decode']($value, $document, $this, $skip);
}
Comment on lines 8472 to 8476
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Skip logic no longer applied for built-in filters

The $skip flag is now delegated to each filter's decode callback, but none of the built-in filter implementations (json, datetime, point, linestring, polygon, vector, object) accept or inspect this fourth parameter — PHP silently ignores the extra argument. As a result, calling skipFilters(['datetime']) (or disableFilters()) no longer prevents the decode callback from running; the value is still decoded. The previous code returned early before calling the callback at all when $skip was true.

External instance filters registered by callers are affected the same way — they receive an undocumented fourth argument they almost certainly don't handle.


Comment thread
fogelito marked this conversation as resolved.
return $value;
Expand Down