Skip to content

Filter use break #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abnegate merged 3 commits into from
Feb 12, 2026
Merged

Filter use break #808

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c60a502
break
fogelito Feb 12, 2026
28e1de3
break
fogelito Feb 12, 2026
ef60326
Update test
fogelito Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Database/Validator/Query/Filter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ protected function isValidAttributeAndValues(string $attribute, array $values, s
// For dotted attributes on objects, validate as string (path queries)
if ($isDottedOnObject) {
$validator = new Text(0, 0);
continue 2;
break;
}

// object containment queries on the base object attribute
Expand Down
10 changes: 10 additions & 0 deletions tests/e2e/Adapter/Scopes/ObjectAttributeTests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1379,6 +1379,16 @@ public function testNestedObjectAttributeEdgeCases(): void
])
]);

try {
$database->find($collectionId, [
Query::equal('profile.level1.level2.level3.level4.value', [10])
]);
$this->fail('Expected nesting as string');
} catch (Exception $e) {
$this->assertInstanceOf(QueryException::class, $e);
$this->assertEquals('Invalid query: Query value is invalid for attribute "profile"', $e->getMessage());
}

$results = $database->find($collectionId, [
Query::equal('profile.level1.level2.level3.level4.value', ['deep_value_1'])
]);
Expand Down
Loading