Fix fpm cookie tests

Author: lohanidamodar

src/Http/Adapter/Swoole/Request.php

@@ -392,7 +392,19 @@ protected function generateInput(): array
      */
     protected function generateHeaders(): array
     {
-        $headers = $this->swoole->header;
+        $headers = $this->swoole->header ?? [];
+
+        // Check if cookies are available in a separate property
+        if (!empty($this->swoole->cookie)) {
+            // Convert cookies back to Cookie header format
+            $cookiePairs = [];
+            foreach ($this->swoole->cookie as $name => $value) {
+                $cookiePairs[] = $name . '=' . $value;
+            }
+            if (!empty($cookiePairs)) {
+                $headers['cookie'] = implode('; ', $cookiePairs);
+            }
+        }
 
         foreach ($headers as $key => $value) {
             $headers[strtolower($key)] = $value;

tests/e2e/BaseTest.php

@@ -95,11 +95,16 @@ public function testCookie()
         $this->assertEquals(200, $response['headers']['status-code']);
         $this->assertEquals($cookie, $response['body']);
 
+        /**
+         * Cookie response always expecting space in multiple cookie
+         * as RFC 6265 (https://datatracker.ietf.org/doc/html/rfc6265#section-4.2.1) recommends it
+         */
+
         // Two cookies without optional space
         $cookie = 'cookie1=value1;cookie2=value2';
         $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie' => $cookie ]);
         $this->assertEquals(200, $response['headers']['status-code']);
-        $this->assertEquals($cookie, $response['body']);
+        $this->assertEquals('cookie1=value1; cookie2=value2', $response['body']);
 
         // Cookie with "=" in value
         $cookie = 'cookie1=value1=value2';
@@ -108,10 +113,10 @@ public function testCookie()
         $this->assertEquals($cookie, $response['body']);
 
         // Case sensitivity for cookie names
-        $cookie = 'cookie1=v1; Cookie1=v2';
+        $cookie = 'cookie1=v1;Cookie1=v2';
         $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie' => $cookie ]);
         $this->assertEquals(200, $response['headers']['status-code']);
-        $this->assertEquals($cookie, $response['body']);
+        $this->assertEquals('cookie1=v1; Cookie1=v2', $response['body']);
     }
 
     public function testSetCookie()

tests/e2e/ResponseFPMTest.php

@@ -14,4 +14,41 @@ public function setUp(): void
     {
         $this->client = new Client('http://fpm');
     }
+
+    /**
+     * Override cookie test for FPM specific behavior
+     * FPM preserves original cookie format while Swoole normalizes it
+     */
+    public function testCookie()
+    {
+        // One cookie
+        $cookie = 'cookie1=value1';
+        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie' => $cookie ]);
+        $this->assertEquals(200, $response['headers']['status-code']);
+        $this->assertEquals($cookie, $response['body']);
+
+        // Two cookies with space (FPM preserves original format)
+        $cookie = 'cookie1=value1; cookie2=value2';
+        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie' => $cookie ]);
+        $this->assertEquals(200, $response['headers']['status-code']);
+        $this->assertEquals($cookie, $response['body']);
+
+        // Two cookies without space (FPM preserves original format)
+        $cookie = 'cookie1=value1;cookie2=value2';
+        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie' => $cookie ]);
+        $this->assertEquals(200, $response['headers']['status-code']);
+        $this->assertEquals($cookie, $response['body']);
+
+        // Cookie with "=" in value
+        $cookie = 'cookie1=value1=value2';
+        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie' => $cookie ]);
+        $this->assertEquals(200, $response['headers']['status-code']);
+        $this->assertEquals($cookie, $response['body']);
+
+        // Case sensitivity for cookie names
+        $cookie = 'cookie1=v1; Cookie1=v2';
+        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie' => $cookie ]);
+        $this->assertEquals(200, $response['headers']['status-code']);
+        $this->assertEquals($cookie, $response['body']);
+    }
 }