Skip to content

Commit 331a716

Browse files
loks0nclaude
andcommitted
Assert route identity in http RouterTest
assertNotEquals deep-compares two different Route instances, and the cyclic Route object graph overflows the stack under newer sebastian/comparator releases (7.1.8). Router::match returns the registered instance, so identity is the assertion that was meant. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent b0dd8cc commit 331a716

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

tests/RouterTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,11 @@ public function testCanMatchHttpMethod(): void
7777
Router::addRoute($routeGET);
7878
Router::addRoute($routePOST);
7979

80-
$this->assertEquals($routeGET, Router::match(Http::REQUEST_METHOD_GET, '/')?->route);
81-
$this->assertEquals($routePOST, Router::match(Http::REQUEST_METHOD_POST, '/')?->route);
80+
$this->assertSame($routeGET, Router::match(Http::REQUEST_METHOD_GET, '/')?->route);
81+
$this->assertSame($routePOST, Router::match(Http::REQUEST_METHOD_POST, '/')?->route);
8282

83-
$this->assertNotEquals($routeGET, Router::match(Http::REQUEST_METHOD_POST, '/')?->route);
84-
$this->assertNotEquals($routePOST, Router::match(Http::REQUEST_METHOD_GET, '/')?->route);
83+
$this->assertNotSame($routeGET, Router::match(Http::REQUEST_METHOD_POST, '/')?->route);
84+
$this->assertNotSame($routePOST, Router::match(Http::REQUEST_METHOD_GET, '/')?->route);
8585
}
8686

8787
public function testCanMatchAlias(): void

0 commit comments

Comments
 (0)