Fix tests usage

Author: lohanidamodar

src/Http/Request.php

@@ -504,32 +504,7 @@ public function setPayload(array $params): static
      *
      * @return array
      */
-    protected function generateHeaders(): array
-    {
-        if (null === $this->headers) {
-            /**
-             * Fallback for older PHP versions
-             * that do not support generateHeaders
-             */
-            if (!\function_exists('getallheaders')) {
-                $headers = [];
-
-                foreach ($_SERVER as $name => $value) {
-                    if (\substr($name, 0, 5) == 'HTTP_') {
-                        $headers[\str_replace(' ', '-', \strtolower(\str_replace('_', ' ', \substr($name, 5))))] = $value;
-                    }
-                }
-
-                $this->headers = $headers;
-
-                return $this->headers;
-            }
-
-            $this->headers = array_change_key_case(getallheaders());
-        }
-
-        return $this->headers;
-    }
+    abstract protected function generateHeaders(): array;
 
     /**
      * Generate input

tests/e2e/BaseTest.php

@@ -85,31 +85,31 @@ public function testCookie()
     {
         // One cookie
         $cookie = 'cookie1=value1';
-        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie: ' . $cookie ]);
+        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie' => $cookie ]);
         $this->assertEquals(200, $response['headers']['status-code']);
         $this->assertEquals($cookie, $response['body']);
 
         // Two cookiees
         $cookie = 'cookie1=value1; cookie2=value2';
-        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie: ' . $cookie ]);
+        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie' => $cookie ]);
         $this->assertEquals(200, $response['headers']['status-code']);
         $this->assertEquals($cookie, $response['body']);
 
         // Two cookies without optional space
         $cookie = 'cookie1=value1;cookie2=value2';
-        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie: ' . $cookie ]);
+        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie' => $cookie ]);
         $this->assertEquals(200, $response['headers']['status-code']);
         $this->assertEquals($cookie, $response['body']);
 
         // Cookie with "=" in value
         $cookie = 'cookie1=value1=value2';
-        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie: ' . $cookie ]);
+        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie' => $cookie ]);
         $this->assertEquals(200, $response['headers']['status-code']);
         $this->assertEquals($cookie, $response['body']);
 
         // Case sensitivity for cookie names
         $cookie = 'cookie1=v1; Cookie1=v2';
-        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie: ' . $cookie ]);
+        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie' => $cookie ]);
         $this->assertEquals(200, $response['headers']['status-code']);
         $this->assertEquals($cookie, $response['body']);
     }

tests/e2e/init.php

@@ -84,8 +84,8 @@
     ->inject('request')
     ->inject('response')
     ->action(function (Request $request, Response $response) {
-        $response->addHeader('Set-Cookie', 'key1=value1');
-        $response->addHeader('Set-Cookie', 'key2=value2');
+        $response->addHeader('Set-Cookie', 'key1=value1', false);
+        $response->addHeader('Set-Cookie', 'key2=value2', false);
         $response->send('OK');
     });