Merge pull request #142 from ebenezerdon/fix-preserve-numeric-segments

Fix: preserve numeric segments in path matching

Author: TorstenDittmann

.gitignore

@@ -1,3 +1,5 @@
 /vendor/
 /.idea/
-*.cache
+*.cache
+.history
+.phpactor.json

src/Http/Router.php

@@ -123,7 +123,7 @@ public static function match(string $method, string $path): Route|null
             return null;
         }
 
-        $parts = array_values(array_filter(explode('/', $path)));
+        $parts = array_values(array_filter(explode('/', $path), fn ($segment) => $segment !== ''));
         $length = count($parts) - 1;
         $filteredParams = array_filter(self::$params, fn ($i) => $i <= $length);
 

tests/RouterTest.php

@@ -47,6 +47,7 @@ public function testCanMatchUrlWithPlaceholder(): void
         $this->assertEquals($routeBlogAuthorsComments, Router::match(Http::REQUEST_METHOD_GET, '/blog/authors/comments'));
         $this->assertEquals($routeBlogPost, Router::match(Http::REQUEST_METHOD_GET, '/blog/test'));
         $this->assertEquals($routeBlogPostComments, Router::match(Http::REQUEST_METHOD_GET, '/blog/test/comments'));
+        $this->assertEquals($routeBlogPostCommentsSingle, Router::match(Http::REQUEST_METHOD_GET, '/blog/test/comments/0'));
         $this->assertEquals($routeBlogPostCommentsSingle, Router::match(Http::REQUEST_METHOD_GET, '/blog/test/comments/:comment'));
     }