Improve domain validator

Author: Meldiron

src/Http/Validator/Domain.php

@@ -45,7 +45,11 @@ public function isValid($value): bool
             return false;
         }
 
-        if (\filter_var($value, FILTER_VALIDATE_DOMAIN) === false) {
+        if (\filter_var($value, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME) === false) {
+            return false;
+        }
+
+        if(\str_ends_with($value, '.')) {
             return false;
         }
 

tests/Validator/DomainTest.php

@@ -27,6 +27,17 @@ public function testIsValid()
         $this->assertEquals(true, $this->domain->isValid('example.org'));
         $this->assertEquals(true, $this->domain->isValid('example.org'));
         $this->assertEquals(false, $this->domain->isValid(false));
+        $this->assertEquals(false, $this->domain->isValid('api.appwrite.io.'));
+        $this->assertEquals(false, $this->domain->isValid('.api.appwrite.io'));
+        $this->assertEquals(false, $this->domain->isValid('.api.appwrite.io'));
+        $this->assertEquals(false, $this->domain->isValid('api..appwrite.io'));
+        $this->assertEquals(false, $this->domain->isValid('api-.appwrite.io'));
+        $this->assertEquals(false, $this->domain->isValid('api.-appwrite.io'));
+        $this->assertEquals(false, $this->domain->isValid('app write.io'));
+        $this->assertEquals(false, $this->domain->isValid(' appwrite.io'));
+        $this->assertEquals(false, $this->domain->isValid('appwrite.io '));
+        $this->assertEquals(false, $this->domain->isValid('-appwrite.io'));
+        $this->assertEquals(false, $this->domain->isValid('appwrite.io-'));
         $this->assertEquals(false, $this->domain->isValid('.'));
         $this->assertEquals(false, $this->domain->isValid('..'));
         $this->assertEquals(false, $this->domain->isValid(''));