Logical fixes & new tests

Author: Meldiron

src/Http/Adapter/Swoole/Request.php

@@ -260,9 +260,8 @@ public function getCookie(string $key, string $default = ''): string
             $cookie = \trim($cookie);
             [$cookieKey, $cookieValue] = \explode('=', $cookie, 2);
             $cookieKey = \trim($cookieKey);
-            $cookieKey = \strtolower($cookieKey);
             $cookieValue = \trim($cookieValue);
-            if ($cookieValue === $key) {
+            if ($cookieKey === $key) {
                 return $cookieValue;
             }
         }

tests/e2e/BaseTest.php

@@ -38,25 +38,33 @@ public function testFile()
 
     public function testCookie()
     {
+        // One cookie
         $cookie = 'cookie1=value1';
-        $response = $this->client->call(Client::METHOD_GET, '/cookies', [
-            'Cookie: ' . $cookie
-        ]);
+        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie: ' . $cookie ]);
         $this->assertEquals(200, $response['headers']['status-code']);
         $this->assertEquals($cookie, $response['body']);
 
+        // Two cookiees
         $cookie = 'cookie1=value1; cookie2=value2';
-        $response = $this->client->call(Client::METHOD_GET, '/cookies', [
-            'Cookie: ' . $cookie
-        ]);
+        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie: ' . $cookie ]);
         $this->assertEquals(200, $response['headers']['status-code']);
         $this->assertEquals($cookie, $response['body']);
 
-
+        // Two cookies without optional space
         $cookie = 'cookie1=value1;cookie2=value2';
-        $response = $this->client->call(Client::METHOD_GET, '/cookies', [
-            'Cookie: ' . $cookie
-        ]);
+        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie: ' . $cookie ]);
+        $this->assertEquals(200, $response['headers']['status-code']);
+        $this->assertEquals($cookie, $response['body']);
+
+        // Cookie with "=" in value
+        $cookie = 'cookie1=value1=value2';
+        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie: ' . $cookie ]);
+        $this->assertEquals(200, $response['headers']['status-code']);
+        $this->assertEquals($cookie, $response['body']);
+
+        // Case sensitivity for cookie names
+        $cookie = 'cookie1=v1; Cookie1=v2';
+        $response = $this->client->call(Client::METHOD_GET, '/cookies', [ 'Cookie: ' . $cookie ]);
         $this->assertEquals(200, $response['headers']['status-code']);
         $this->assertEquals($cookie, $response['body']);
     }