Validate route methods before registration

Author: ChiragAgg5k

src/Http/Http.php

@@ -238,6 +238,14 @@ public static function routes(string|array $methods, string $url): Route
             throw new \Exception('At least one HTTP method is required.');
         }
 
+        $routes = Router::getRoutes();
+
+        foreach ($methods as $method) {
+            if (!\array_key_exists($method, $routes)) {
+                throw new \Exception("Method ({$method}) not supported.");
+            }
+        }
+
         $route = new Route($methods[0], $url, \array_slice($methods, 1));
         Router::addRoute($route);
 

tests/RouterTest.php

@@ -219,6 +219,24 @@ public function testCannotRegisterRouteForUnknownMethod(): void
         Http::routes([Http::REQUEST_METHOD_GET, 'TRACE'], '/userinfo');
     }
 
+    public function testUnknownMethodDoesNotPartiallyRegisterRoute(): void
+    {
+        try {
+            Http::routes([Http::REQUEST_METHOD_GET, 'TRACE'], '/userinfo');
+            $this->fail('Expected unknown method exception.');
+        } catch (\Exception $exception) {
+            $this->assertSame('Method (TRACE) not supported.', $exception->getMessage());
+        }
+
+        $routes = Router::getRoutes();
+        $this->assertArrayNotHasKey('userinfo', $routes[Http::REQUEST_METHOD_GET]);
+
+        $route = Http::routes([Http::REQUEST_METHOD_GET, Http::REQUEST_METHOD_POST], '/userinfo');
+
+        $this->assertEquals($route, Router::match(Http::REQUEST_METHOD_GET, '/userinfo')?->route);
+        $this->assertEquals($route, Router::match(Http::REQUEST_METHOD_POST, '/userinfo')?->route);
+    }
+
     public function testCannotRegisterRouteWithoutMethods(): void
     {
         $this->expectException(\Exception::class);