Skip to content

Add non-coroutine Swoole HTTP server adapter#229

Closed
ChiragAgg5k wants to merge 1 commit into0.34.xfrom
feat-swoole-http-server
Closed

Add non-coroutine Swoole HTTP server adapter#229
ChiragAgg5k wants to merge 1 commit into0.34.xfrom
feat-swoole-http-server

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

Summary

  • Adds HttpServer adapter class wrapping Swoole\Http\Server for the traditional multi-process server model with worker management and graceful reload
  • Uses on('request') / on('start') event-based API instead of coroutine handle() / immediate callback
  • Fully interchangeable with the existing coroutine-based Server adapter via the Adapter contract
  • Zero changes to existing files — no breaking changes

Test plan

  • Existing tests pass unchanged (no modifications to Server, Adapter, or Http)
  • New test entry point tests/e2e/server-swoole-http.php boots and serves requests with HttpServer
  • Http class works with both Server and HttpServer interchangeably

Add HttpServer adapter class that wraps Swoole\Http\Server for users
who need the traditional multi-process server with worker management
and graceful reload, as an alternative to the existing coroutine-based
Server adapter. Both adapters implement the same Adapter contract and
are interchangeable.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6fe5c237-b0c3-403d-8807-e96321947251

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-swoole-http-server
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant