You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docs: clarify resolver scope — when source/destination DSNs differ
"Cross-instance migrations" was ambiguous: it read like cloud-to-cloud
or dedicated-DB migration. The actual scope is narrower — any case
where the source project's stored DSN doesn't apply to the destination
project (cross-host within the same instance, cross-region, mixed
shared-tables migration). Reword the property, constructor, and
inline write-site comments to say that explicitly.
* @param OnDuplicate $onDuplicate Behavior when a row with an existing $id is encountered.
153
-
* @param (callable(Database $resource): string)|null $getDatabaseDSN Resolver for the destination's `_databases.database` value. Required for cross-instance migrations to prevent the source DSN from being written into the destination project's metadata.
155
+
* @param (callable(Database $resource): string)|null $getDatabaseDSN Resolver for the destination's `_databases.database` value. Pass when the destination project's DSN differs from the source's, so the destination row carries its own DSN instead of inheriting the source's.
154
156
*/
155
157
publicfunction__construct(
156
158
string$project,
@@ -185,8 +187,9 @@ public function __construct(
185
187
/**
186
188
* Resolve the DSN written into the destination's `_databases.database`.
187
189
* Without a resolver, leave it blank — the source DSN must never be
188
-
* propagated, since cross-instance source/destination DSNs differ and
189
-
* propagation routes destination reads to the wrong host (see PR #151).
190
+
* propagated as the default, since when source and destination DSNs
191
+
* differ propagation routes destination reads to the wrong host (the
0 commit comments