Skip to content

Commit 98c9972

Browse files
committed
Add missing fallbacks
1 parent 7c00ac4 commit 98c9972

1 file changed

Lines changed: 9 additions & 10 deletions

File tree

  • src/Migration/Sources/Appwrite/Reader

src/Migration/Sources/Appwrite/Reader/API.php

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -74,34 +74,33 @@ public function report(array $resources, array &$report): mixed
7474
: [Query::limit($pageLimit)]
7575
)['collections']; /* ['tables'] */
7676

77-
$tables = array_merge($tables, $currentTables);
77+
$tables = \array_merge($tables, $currentTables);
7878
$lastTable = $tables[count($tables) - 1]['$id'] ?? null;
7979

80-
if (count($currentTables) < $pageLimit) {
80+
if (\count($currentTables) < $pageLimit) {
8181
break;
8282
}
8383
}
8484

85-
if (Resource::isSupported(Resource::TYPE_TABLE, $resources)) {
86-
$report[Resource::TYPE_TABLE] += count($tables);
85+
if (Resource::isSupported([Resource::TYPE_TABLE, Resource::TYPE_COLLECTION], $resources)) {
86+
$report[Resource::TYPE_TABLE] += \count($tables);
8787
}
8888

8989
if (Resource::isSupported([Resource::TYPE_ROW, Resource::TYPE_COLUMN, Resource::TYPE_INDEX], $resources)) {
9090
foreach ($tables as $table) {
9191
$tableId = $table['$id'];
9292

93-
if (Resource::isSupported(Resource::TYPE_COLUMN, $resources)) {
93+
if (Resource::isSupported([Resource::TYPE_COLUMN, Resource::TYPE_ATTRIBUTE], $resources)) {
9494
// a table already returns a list of attributes
9595
$report[Resource::TYPE_COLUMN] += count($table['columns'] ?? $table['attributes'] ?? []);
9696
}
9797

98-
if (in_array(Resource::TYPE_INDEX, $resources)) {
99-
// a table already returns a list of indexes
100-
$report[Resource::TYPE_INDEX] += count($table['indexes'] ?? []);
98+
if (\in_array(Resource::TYPE_INDEX, $resources)) {
99+
// A table already returns a list of indexes
100+
$report[Resource::TYPE_INDEX] += \count($table['indexes'] ?? []);
101101
}
102102

103-
// this one's a bit heavy if the number of tables are high!
104-
if (Resource::isSupported(Resource::TYPE_ROW, $resources)) {
103+
if (Resource::isSupported([Resource::TYPE_ROW, Resource::TYPE_DOCUMENT], $resources)) {
105104
/* $rowsResponse = $this->tables->listRows(...) */
106105
$rowsResponse = $this->database->listDocuments(
107106
$databaseId,

0 commit comments

Comments
 (0)